-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activity stream #557
Comments
Here’s the mockup of the activity stream merged with notifications as @mario and I talked about: From the writeup in the sidebar issue: #556 (comment)
|
Keep in mind that there should be an option to filter the activities by "recently added", "recently modified" and "shared files". |
@MorrisJobke you mean Files themselves, not activities? |
Didn't we want to put this into the activities, because there is no other API where we can get the "recently added"/... stuff from? |
I can get shared files I believe in a flat list, right @icewind1991? As for the rest, I can read modification/creation date? (I believe so, please correct me if I'm wrong) |
But not across all files. The modified date can only be read for the listed files. |
@icewind1991 should be able to get me a flat list of recently modified (say modified in the last three days) via new webdav search, right? :) |
Oh - didn't know that one :) |
No, I was telling him to implement it :P |
The api should support that yes |
@MorrisJobke so? We're putting it in the sidebar as a Files "filter"/view, right? Rather than activity filter? |
Yes. |
We can have the views »Activity« and »Recent«. The latter could basically be a shortcut to the file list but sorted by most recently modified (which includes recently added). Uploads and modifications are part of activity too of course. |
@nickvergessen I talked to @jancborchardt about how activities should be displayed and the idea is to have it basically look like on the web: How can I distinguish all the different "activities"? Since they
|
Mmh. Is it possible to create one 'removed' and one 'shared' folder and collect all shares in that? |
On API v1 that is not possible. On API v2 all the necessary information is available. I had to finish all the other tasks for 12 first. It's still on my todo. |
PR is in nextcloud/activity#125 |
@nickvergessen is there a documentation of the data structure/json so I can support @mario with the UI part but already having the UI part and the UIs data structures in place (at least in some 90% way)? |
Sure, see the post above. Only the URL is not correct. That is fixed in the PR: |
@AndyScherzinger and a big missing important part is the actual file and the file preview :) |
@jancborchardt where would I see that? The Mockup is a screenshot from the web ui ?! (v.11.0.2 though) |
@AndyScherzinger here’s some proper screenshots from how it looks like since some versions :) |
@jancborchardt oh, I simply looked at the right frame when you click on a file... |
@jancborchardt and also I'd guess the first iteration will likely be simpler. What do you think @mario @aleister09 ? |
@AndyScherzinger indeed, all the rich stuff won't be in the first implementation. |
@AndyScherzinger aaah, makes sense. :D Yeah no, the activity list should look like the Activity app, because it’s about all files of course. :) What’s to be kept simpler there? It’s already pretty boiled down to the essentials. And we have info like file names, filetype icons, action type, person who changed it (+avatar) and date, right? |
@jancborchardt the API (at least for notifications) has 2 versions, where v2 brings in Rich subject and message where you get a string with placeholders and a key/value list for it and v1 brings subject and message where all placeholders are already substituted. So to make it look the way it does for web we need to processed the rich message/subject which means we need to parse the text, replace the placeholders, add so called spans which it a bit trickier than on web, fetch&cache avatars/thumbnails/previews. This can be done for sure but it is also very time consuming, so imho depends on the timeline. Thus a first iteration could use the non-rich strings (basically plain text then! No images, avatars, previews etc.) and a second iteration would use the rich strings (then with the content also seen on the web UI). To some extend we might even have to support both anyways or only offer this feature for servers with v2 of the API present! |
So in the first iteration the app will show just the plain text (subject) and the icon type sorted by date? |
Recycler view and nothing for now.
You can show both the subject and the message.
|
@mario also do i need to implement the remote operation for activities in android-library? |
@aleister09 yes. Let me know if you need a hand. |
@aleister09 the current code already contains a method to convert datetime to human friendly format you need (I'd need to look it up), and you should be able to find the place to extend the DB to store activities relatively easily. Let me know if not, and I'll help you out. |
|
There, @AndyScherzinger has it. And @jancborchardt posted how it should look (kind-of). |
Well, in the first iteration not using the rich objects we won't be able to do the bold/avatar things since we don't know what part of the string would need to be styled... |
@AndyScherzinger of course, we already agreed on that :) |
@mario just to be sure, First I need to implement the remote operation on android-library then extend the DB to store activities and call the remote operation to show the result, Right? |
@aleister09 welcome to the Nextcloud community! :) Awesome to have you and looking forward to your contributions. |
Well, you call the remote operation, get the activities, store new ones in
DB and then show them from the database :)
|
@mario I finished the first view of activities, I used the activity_item.xml like @AndyScherzinger suggested to me For this first iteration Should I add the header with the date? and Do you have the icons to match them with the activity's type? I will work with the DB Store |
@aleister09 no need. For the icon - it should be in the payload under 'icon'. Is it not there? @nickvergessen can you please confirm he should be getting the icon back? :) |
Yup, It's there, sorry I didn't see it =) |
@aleister09 cool. The library to use for showing SVGs is androidsvg I guess: compile 'com.caverock:androidsvg:1.2.1' |
#784 the initial implementation with simple text has been merged to master |
Basic activity stream implementation should be done without actually linking to files and such in the first iteration - but will include previews.
According to @nickvergessen API for this should be available in v12.
I'd appreciate all input from the @nextcloud/designers team on how the actual screen and items should look like.
@tobiasKaminsky and @AndyScherzinger - you're more than welcome to chime in as well.
The text was updated successfully, but these errors were encountered: