Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show age instead of birth year #940

Open
johkoenig opened this issue Nov 6, 2018 · 11 comments
Open

Show age instead of birth year #940

johkoenig opened this issue Nov 6, 2018 · 11 comments
Labels
1. to develop Accepted and waiting to be taken care of enhancement New feature request Feature: Birthday Calendar

Comments

@johkoenig
Copy link
Member

johkoenig commented Nov 6, 2018

Steps to reproduce

  1. Add people with birthdays to your contacts app
  2. Have a look at the birthday calendar

Expected behaviour

If somebody is born on August 1st, 1976, then the calendar of August 2018 should show "John Doe (42)"
The birthday date could be atted to the notes.

Actual behaviour

The calendar shows "John Doe (*1976)".

Server configuration

Server version: 14.0.3
Calendar version: 1.6.3


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@georgehrke georgehrke added 1. to develop Accepted and waiting to be taken care of enhancement New feature request labels Nov 6, 2018
@georgehrke georgehrke added this to the 2.2.0 milestone Nov 6, 2018
@tcitworld
Copy link
Member

Isn't this a server issue ?

@georgehrke
Copy link
Member

@tcitworld Displaying the age is nothing we can practically do on the server, because it prevents us from using RRULE.
My idea was to introduce a property that stores just the birth year and to generate the age in browser: https://github.com/nextcloud/server/pull/11832/files#diff-e96c57f9fa60e361112de26af7457146R247

@johkoenig
Copy link
Member Author

This probably needs some larger remodeling. As far as I can see it out of your code, right now you're creating a series appointment every year with the same text "John Doe (*1976)". You'll probably need to recode this to create a single appointment each year with a different text "John Doe (1)", "John Doe (2)", ...
I don't know if theres a nicer way of doing this.

@georgehrke
Copy link
Member

You'll probably need to recode this to create a single appointment each year with a different text "John Doe (1)", "John Doe (2)",

@johkoenig Then we end up having at least 100 times as many birthday events, not to mention that updating a contact will also result in 100 update queries ....
So that's not really something I'm willing to do.

My idea was to keep John Doe (*1976) in the ics files (so mobile / desktop clients still see that), but then calculate the actual age in the calendar app.

@johkoenig
Copy link
Member Author

The downside of this is that e.g. in Thunderbird, I still only see John Doe (*1976). On the iPhone it's not so much of a problem, because the iPhone creates a birthday calendar by itself. I don't know how android handles this.

@tcitworld
Copy link
Member

@johkoenig If you want to discuss this more feel free to open an issue in the server repo.

@ypid-geberit
Copy link

I don't know how android handles this.

The Android Open Source Project (AOSP) as of 9.0 does not handle this e.g. does not support a birthday calendar. Non-vanilla Android versions (vendor modified) might have native support for this. In any case, Birthday Adapter does exactly what you proposed (generates calendar events like "John Doe (42)").

@johkoenig
Copy link
Member Author

@ypid-geberit Thats good to know. My iPhone does the same, based on the data from the contact storage.
However, this issue is about the nextcloud calender.
@tcitworld I'll carry it over to server.

@georgehrke georgehrke modified the milestones: 2.2.0, 2.0.0 beta3 Sep 9, 2019
@georgehrke georgehrke modified the milestones: 2.0.0 beta3, 2.0.0 beta4 Dec 9, 2019
@georgehrke georgehrke modified the milestones: 2.0.0 RC, 2.0.1 Jan 14, 2020
@georgehrke georgehrke modified the milestones: 2.0.2, 2.0.3 Feb 27, 2020
@georgehrke georgehrke modified the milestones: 2.0.3, 2.1.0 Apr 2, 2020
@georgehrke georgehrke modified the milestones: 2.1.0, 2.2.0 Sep 4, 2020
@ChristophWurst ChristophWurst modified the milestones: 2.2.0, 2.3.0 Mar 24, 2021
@call-me-matt
Copy link
Member

I am very interested in this feature, too. In case there is a solution, I would love it if round birthdays could be highlighted so I can consider them in my planning without the need to check each entry.

@ChristophWurst ChristophWurst modified the milestones: v2.3.0, v2.4.0 Jun 24, 2021
@pxlfrk

This comment was marked as duplicate.

@hartmann-daniel
Copy link

Hello.

I would also prefer to see the age instead of the year of birth. I understand the problem with the recurring appointments. For the age in the title, an entry would have to be created for each year.

My suggestion. Make the following feature optionally activatable in the settings:
"Show the age in the calendar entry instead of the year of birth"
... Create birthday entries only for x (adjustable) years retrospectively and in the future.

That would be a perfect solution for me.

What do you think?

@joshtrichards joshtrichards changed the title birthday calendar: show age instead of birth year Show age instead of birth year Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of enhancement New feature request Feature: Birthday Calendar
Projects
None yet
Development

No branches or pull requests

9 participants