Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlighting doesn't work properly in code blocks (view mode) #866

Closed
theroch opened this issue Sep 7, 2023 · 4 comments
Closed
Labels
bug Something isn't working

Comments

@theroch
Copy link

theroch commented Sep 7, 2023

Describe the bug
See description in nextcloud/text#3618
We've tested it on 27.0.2. The syntax highlighting is working properly in edit mode but in the view mode it doesn't.

@max-nextcloud said:
"It's fixed in text but we need to release a new version of collectives with that uses the new version of text for view mode.
We're working on it and the fix will automatically land in collectives then.
So please open a new issue in collectives to document this is still missing."

To Reproduce
Steps to reproduce the behavior:
See in nextcloud/text#3618

Expected behavior
Syntax highlighting should work in view mode

Screenshots
If applicable, add screenshots to help explain your problem.

Client details:

  • OS: Windows 10
  • Browser: Firefox
  • Version: 117
  • Device: desktop
Server details

Collectives app version: 2.7.0

Operating system: Ubuntu 22.04

Web server: Apache 2.4

Database: MySQL

PHP version: 8.1

Nextcloud version: 27.0.2

@theroch theroch added the bug Something isn't working label Sep 7, 2023
@juliushaertl
Copy link
Member

I think the library is up to date, we just lack #834 for properly loading the dynamic assets on the last release. This also causes mermaid diagrams to not render in read mode

@theroch
Copy link
Author

theroch commented Sep 8, 2023

I think the library is up to date, we just lack #834 for properly loading the dynamic assets on the last release. This also causes mermaid diagrams to not render in read mode

This means it will be fixed with the next release of collectives?

@juliushaertl
Copy link
Member

Yes :)

@mejo-
Copy link
Member

mejo- commented Sep 11, 2023

This will be fixed with the upcoming 2.7.1 release indeed ☺️

@mejo- mejo- closed this as completed Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants