From 38896f1425fba0619019f8ad7c3700885d507474 Mon Sep 17 00:00:00 2001
From: suntala <33031346+suntala@users.noreply.github.com>
Date: Tue, 25 Sep 2018 18:19:07 +0200
Subject: [PATCH] Add popover menu for purpose of checking methods. #603

---
 package-lock.json                             | 34 +++++++++----------
 src/components/ContactDetails.vue             | 21 ++++++++++++
 .../ContactDetails/ContactDetailsAvatar.vue   |  7 ++--
 3 files changed, 42 insertions(+), 20 deletions(-)

diff --git a/package-lock.json b/package-lock.json
index ce1784136..3de8c8dc8 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -3543,7 +3543,7 @@
 		},
 		"babel-plugin-istanbul": {
 			"version": "4.1.6",
-			"resolved": "http://registry.npmjs.org/babel-plugin-istanbul/-/babel-plugin-istanbul-4.1.6.tgz",
+			"resolved": "https://registry.npmjs.org/babel-plugin-istanbul/-/babel-plugin-istanbul-4.1.6.tgz",
 			"integrity": "sha512-PWP9FQ1AhZhS01T/4qLSKoHGY/xvkZdVBGlKM/HuxxS3+sC66HhTNR7+MpbO/so/cz/wY94MeSWJuP1hXIPfwQ==",
 			"dev": true,
 			"requires": {
@@ -3561,7 +3561,7 @@
 		},
 		"babel-plugin-syntax-object-rest-spread": {
 			"version": "6.13.0",
-			"resolved": "http://registry.npmjs.org/babel-plugin-syntax-object-rest-spread/-/babel-plugin-syntax-object-rest-spread-6.13.0.tgz",
+			"resolved": "https://registry.npmjs.org/babel-plugin-syntax-object-rest-spread/-/babel-plugin-syntax-object-rest-spread-6.13.0.tgz",
 			"integrity": "sha1-/WU28rzhODb/o6VFjEkDpZe7O/U=",
 			"dev": true
 		},
@@ -3872,7 +3872,7 @@
 		},
 		"browserify-aes": {
 			"version": "1.2.0",
-			"resolved": "http://registry.npmjs.org/browserify-aes/-/browserify-aes-1.2.0.tgz",
+			"resolved": "https://registry.npmjs.org/browserify-aes/-/browserify-aes-1.2.0.tgz",
 			"integrity": "sha512-+7CHXqGuspUn/Sl5aO7Ea0xWGAtETPXNSAjHo48JfLdPWcMng33Xe4znFvQweqc/uzk5zSOI3H52CYnjCfb5hA==",
 			"dev": true,
 			"requires": {
@@ -3909,7 +3909,7 @@
 		},
 		"browserify-rsa": {
 			"version": "4.0.1",
-			"resolved": "http://registry.npmjs.org/browserify-rsa/-/browserify-rsa-4.0.1.tgz",
+			"resolved": "https://registry.npmjs.org/browserify-rsa/-/browserify-rsa-4.0.1.tgz",
 			"integrity": "sha1-IeCr+vbyApzy+vsTNWenAdQTVSQ=",
 			"dev": true,
 			"requires": {
@@ -4128,13 +4128,16 @@
 			"dev": true
 		},
 		"cdav-library": {
-			"version": "github:nextcloud/cdav-library#62f691ea0e3d9841dd8f6f40c6fb422cc5ffff38",
+			"version": "github:nextcloud/cdav-library#f2babab16d5aca301cad56bf34128a17323250d7",
 			"requires": {
 				"compare-urls": "2.0.0",
 				"davclient.js": "git+https://github.com/owncloud/davclient.js.git#0e5ef1af5d174d9ec10dbe889a415b8f481d5094",
 				"normalize-url": "3.3.0"
 			},
 			"dependencies": {
+				"davclient.js": {
+					"version": "git+https://github.com/owncloud/davclient.js.git#0e5ef1af5d174d9ec10dbe889a415b8f481d5094"
+				},
 				"normalize-url": {
 					"version": "3.3.0",
 					"resolved": "https://registry.npmjs.org/normalize-url/-/normalize-url-3.3.0.tgz",
@@ -4762,7 +4765,7 @@
 		},
 		"create-hash": {
 			"version": "1.2.0",
-			"resolved": "http://registry.npmjs.org/create-hash/-/create-hash-1.2.0.tgz",
+			"resolved": "https://registry.npmjs.org/create-hash/-/create-hash-1.2.0.tgz",
 			"integrity": "sha512-z00bCGNHDG8mHAkP7CtT1qVu+bFQUPjYq/4Iv3C3kWjTFV10zIjfSoeqXo9Asws8gwSHDGj/hl2u4OGIjapeCg==",
 			"dev": true,
 			"requires": {
@@ -4775,7 +4778,7 @@
 		},
 		"create-hmac": {
 			"version": "1.1.7",
-			"resolved": "http://registry.npmjs.org/create-hmac/-/create-hmac-1.1.7.tgz",
+			"resolved": "https://registry.npmjs.org/create-hmac/-/create-hmac-1.1.7.tgz",
 			"integrity": "sha512-MJG9liiZ+ogc4TzUwuvbER1JRdgvUFSB5+VR/g5h82fGaIRWMWddtKBHi7/sVhfjQZ6SehlyhvQYrcYkaUIpLg==",
 			"dev": true,
 			"requires": {
@@ -5017,9 +5020,6 @@
 			"integrity": "sha1-6vQ5/U1ISK105cx9vvIAZyueNFs=",
 			"dev": true
 		},
-		"davclient.js": {
-			"version": "git+https://github.com/owncloud/davclient.js.git#0e5ef1af5d174d9ec10dbe889a415b8f481d5094"
-		},
 		"de-indent": {
 			"version": "1.0.2",
 			"resolved": "https://registry.npmjs.org/de-indent/-/de-indent-1.0.2.tgz",
@@ -5208,7 +5208,7 @@
 		},
 		"diffie-hellman": {
 			"version": "5.0.3",
-			"resolved": "http://registry.npmjs.org/diffie-hellman/-/diffie-hellman-5.0.3.tgz",
+			"resolved": "https://registry.npmjs.org/diffie-hellman/-/diffie-hellman-5.0.3.tgz",
 			"integrity": "sha512-kqag/Nl+f3GwyK25fhUMYj81BUOrZ9IuJsjIcDE5icNM9FJHAVm3VcUDxdLPoQtTuUylWm6ZIknYJwwaPxsUzg==",
 			"dev": true,
 			"requires": {
@@ -11012,7 +11012,7 @@
 		},
 		"parse-asn1": {
 			"version": "5.1.1",
-			"resolved": "http://registry.npmjs.org/parse-asn1/-/parse-asn1-5.1.1.tgz",
+			"resolved": "https://registry.npmjs.org/parse-asn1/-/parse-asn1-5.1.1.tgz",
 			"integrity": "sha512-KPx7flKXg775zZpnp9SxJlz00gTd4BmJ2yJufSc44gMCRrRQ7NSzAcSJQfifuOLgW6bEi+ftrALtsgALeB2Adw==",
 			"dev": true,
 			"requires": {
@@ -12182,7 +12182,7 @@
 		},
 		"public-encrypt": {
 			"version": "4.0.2",
-			"resolved": "http://registry.npmjs.org/public-encrypt/-/public-encrypt-4.0.2.tgz",
+			"resolved": "https://registry.npmjs.org/public-encrypt/-/public-encrypt-4.0.2.tgz",
 			"integrity": "sha512-4kJ5Esocg8X3h8YgJsKAuoesBgB7mqH3eowiDzMUPKiRDDE7E/BqqZD1hnTByIaAFiwAw246YEltSq7tdrOH0Q==",
 			"dev": true,
 			"requires": {
@@ -12833,7 +12833,7 @@
 			"dependencies": {
 				"minimist": {
 					"version": "1.2.0",
-					"resolved": "http://registry.npmjs.org/minimist/-/minimist-1.2.0.tgz",
+					"resolved": "https://registry.npmjs.org/minimist/-/minimist-1.2.0.tgz",
 					"integrity": "sha1-o1AIsg9BOD7sH7kU9M1d95omQoQ=",
 					"dev": true
 				}
@@ -13162,7 +13162,7 @@
 		},
 		"sha.js": {
 			"version": "2.4.11",
-			"resolved": "http://registry.npmjs.org/sha.js/-/sha.js-2.4.11.tgz",
+			"resolved": "https://registry.npmjs.org/sha.js/-/sha.js-2.4.11.tgz",
 			"integrity": "sha512-QMEp5B7cftE7APOjk5Y6xgrbWu+WkLVQwk8JNjZ8nKRciZaByEW6MubieAiToS7+dwvrjGhH8jRXz3MVd0AYqQ==",
 			"dev": true,
 			"requires": {
@@ -15255,7 +15255,7 @@
 			"dependencies": {
 				"minimist": {
 					"version": "1.2.0",
-					"resolved": "http://registry.npmjs.org/minimist/-/minimist-1.2.0.tgz",
+					"resolved": "https://registry.npmjs.org/minimist/-/minimist-1.2.0.tgz",
 					"integrity": "sha1-o1AIsg9BOD7sH7kU9M1d95omQoQ=",
 					"dev": true
 				}
@@ -15775,7 +15775,7 @@
 		},
 		"yargs": {
 			"version": "11.1.0",
-			"resolved": "http://registry.npmjs.org/yargs/-/yargs-11.1.0.tgz",
+			"resolved": "https://registry.npmjs.org/yargs/-/yargs-11.1.0.tgz",
 			"integrity": "sha512-NwW69J42EsCSanF8kyn5upxvjp5ds+t3+udGBeTbFnERA+lF541DDpMawzo4z6W/QrzNM18D+BPMiOBibnFV5A==",
 			"dev": true,
 			"requires": {
diff --git a/src/components/ContactDetails.vue b/src/components/ContactDetails.vue
index d2f619d82..e4d459a8f 100644
--- a/src/components/ContactDetails.vue
+++ b/src/components/ContactDetails.vue
@@ -44,6 +44,10 @@
 				<contact-avatar :contact="contact" />
 				<!-- QUESTION: is it better to pass contact as a prop or get it from the store inside
 				contact-avatar ?  :avatar="contact.photo"-->
+				<!-- temporary popover menu for the purpose of testing methods (WIP, to be deleted) -->
+				<div :class="{open: true}" class="popovermenu">
+					<popover-menu :menu="menu" />
+				</div>
 
 				<!-- fullname, org, title -->
 				<div id="contact-header-infos">
@@ -237,6 +241,23 @@ export default {
 				localContact.updateContact(contact.jCal)
 				return localContact
 			}
+		},
+
+		// building the popover menu for the avatar (WIP, to be deleted)
+		menu() {
+			let menu = [
+				{
+					icon: 'icon-download',
+					text: t('contacts', 'Download')
+					// action: this.deleteContact
+				},
+				{
+					icon: 'icon-delete',
+					text: t('contacts', 'Delete')
+					// action: this.deleteContact
+				}
+			]
+			return menu
 		}
 	},
 
diff --git a/src/components/ContactDetails/ContactDetailsAvatar.vue b/src/components/ContactDetails/ContactDetailsAvatar.vue
index 7e69d434a..f995f1b5f 100644
--- a/src/components/ContactDetails/ContactDetailsAvatar.vue
+++ b/src/components/ContactDetails/ContactDetailsAvatar.vue
@@ -25,8 +25,7 @@ import rfcProps from '../../models/rfcProps';
 	<div id="contact-header-avatar" :class="{'maximised':maximizeAvatar }">
 		<div class="contact-avatar-background" />
 		<img v-if="contact.photo" :src="contact.photo"
-			class="contact-header-avatar__picture"
-			@click="maximise">
+			class="contact-header-avatar__picture">
 		<div class="avatar-options">
 			<input id="contact-avatar-upload" type="file" class="hidden"
 				accept="image/*" @change="processFile">
@@ -37,6 +36,8 @@ import rfcProps from '../../models/rfcProps';
 		</div>
 	</div>
 </template>
+// TODO: add back @click="maximise" to img tag
+// delete the new code in ContactDetails tagged with WIP, to be deleted
 
 <script>
 
@@ -68,7 +69,7 @@ export default {
 		},
 		toggleSize() {
 			// maximise avatar photo
-			this.maximizeAvatar != this.maximizeAvatar
+			this.maximizeAvatar = !this.maximizeAvatar
 		},
 		removePhoto() {
 			// self.contact.vCard.removePropertyWithValue('photo', reader.result)