Merge pull request #1972 from nextcloud/bugfix/noid/direct-url

Fix generating the redirect url
nextcloud · Dec 14, 2020 · b925bf3 · b925bf3
2 parents 49d7d5e + 6d7fd24
commit b925bf3
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/lib/Controller/ContactsController.php b/lib/Controller/ContactsController.php
@@ -56,7 +56,9 @@ public function __construct(IRequest $request,
 	 * @param string $uuid
 	 */
 	public function direct(string $contact): RedirectResponse {
-		$url = $this->urlGenerator->getAbsoluteURL('/apps/contacts/' . $this->l10n->t('All contacts') . '/' . $contact);
+		$url = $this->urlGenerator->getAbsoluteURL(
+			$this->urlGenerator->linkToRoute('contacts.page.index') . $this->l10n->t('All contacts') . '/' . $contact
+		);
 		return new RedirectResponse($url);
 	}
 }
diff --git a/tests/unit/Controller/ContactsControllerTest.php b/tests/unit/Controller/ContactsControllerTest.php
@@ -62,13 +62,18 @@ public function testRedirect() {
 			->with('All contacts')
 			->willReturn('All contacts');
 
+		$this->urlGenerator->expects($this->once())
+			->method('linkToRoute')
+			->with('contacts.page.index')
+			->willReturn('/index.php/apps/contacts/');
+
 		$this->urlGenerator->expects($this->once())
 			->method('getAbsoluteURL')
-			->with('/apps/contacts/All contacts/' . $contact)
-			->willReturn('/apps/contacts/All contacts/' . $contact);
+			->with('/index.php/apps/contacts/All contacts/' . $contact)
+			->willReturn('/index.php/apps/contacts/All contacts/' . $contact);
 
 		$result = $this->controller->direct('uuid~addressbook');
 		$this->assertTrue($result instanceof RedirectResponse);
-		$this->assertEquals('/apps/contacts/All contacts/' . $contact, $result->getRedirectURL());
+		$this->assertEquals('/index.php/apps/contacts/All contacts/' . $contact, $result->getRedirectURL());
 	}
 }