Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Save Contact websites to Bookmarks app #1272

Closed
sunjam opened this issue Sep 23, 2019 · 12 comments
Closed

Feature Request: Save Contact websites to Bookmarks app #1272

sunjam opened this issue Sep 23, 2019 · 12 comments
Labels
1. to develop Accepted and waiting to be taken care of enhancement New feature or request help wanted Extra attention is needed

Comments

@sunjam
Copy link

sunjam commented Sep 23, 2019

Is your feature request related to a problem? Please describe.
This is a useful to have request and not a priority. I'd like to request contact website urls be automatically imported into the excellent Nextcloud Bookmarks app via REST api. That app is maintained by @marcelklehr
If possible, to have a simple user toggle for those wanting to import to the Bookmarks app they have installed.

Describe the solution you'd like
Via Bookmarks REST API

Describe alternatives you've considered
Manually adding the url to bookmarks, but this would be useful to have better integrated.

Screen Shot 2019-09-23 at 11 59 51 AM

@sunjam sunjam added 0. Needs triage enhancement New feature or request labels Sep 23, 2019
@skjnldsv
Copy link
Member

Hey! Thanks for your suggestion!
@marcelklehr, what do you think?

@marcelklehr
Copy link
Member

Like the idea of integrating the notes app with bookmarks, this definitely sounds like a good idea and I think such integrations are incredibly useful. I'm uncertain on the details of how this should look, however. As always, the devil is in details like ideally, bookmarks so created should probably be properly linked to a contact to propagate changes and display the associated contact, also I already foresee a bike shed about where in the bookmarks tree these bookmarks should be put.

@skjnldsv What are your thoughts on this from a UX perspective? Also regarding nextcloud/bookmarks#447

@skjnldsv
Copy link
Member

Ideally a simple direct link to the add bookmark view?

https://c.nc.com/apps/bookmarks/add/http%3A%2F%2Fwww.duckduckgo.com ?

@marcelklehr
Copy link
Member

Ah, I hadn't considered that. I was thinking more along the lines of an automatic integration, but this would be rather simple. The relevant URL would be: c.nc.com/aps/bookmarks#/bookmarklet/<url>/<title?>

@skjnldsv
Copy link
Member

You're using hashes for the new vue bookmarks?

@marcelklehr
Copy link
Member

Yup?

@skjnldsv
Copy link
Member

skjnldsv commented Sep 24, 2019

You can use regular url with vue router :)
Makes it a bit cleaner ;)

edit: see nextcloud/bookmarks#815

@marcelklehr
Copy link
Member

the API is now apps/bookmarks/bookmarklet?url=xxx&title=yyy, because URLs as part of the path apparently cause trouble.

@skjnldsv
Copy link
Member

Fine for me! :D
Any starting version for this? So I'm sure I can stay compatible?

@marcelklehr
Copy link
Member

That'll be v2.2.0 then

@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of good first issue Good for newcomers and removed 0. Needs triage labels Sep 28, 2019
@jancborchardt
Copy link
Member

Design-wise:

  • Instead of the delete icon, we show a 3-dot menu with "Save to Bookmarks" and "Delete" (of course only when Bookmarks is installed)
  • "Save to Bookmarks" simply saves it into the root bookmarks place, no tags or anything
  • Gives tooltip feedback saying "Saved to Bookmarks [ Edit ]" in case people want to edit it.

That’s a simple first implementation, no space for bikeshedding. ;)

@jancborchardt jancborchardt added help wanted Extra attention is needed and removed good first issue Good for newcomers labels Jan 2, 2020
@skjnldsv
Copy link
Member

skjnldsv commented Sep 7, 2020

As this sounds like a nice feature, the requests for this are quite low. Currently there a no plans to implement such a feature. Thus I will close this ticket for now. This does not mean we don't want this feature, but it is simply not on our roadmap for the near future. If somebody wants to implement this feature nevertheless we are happy to assist and help out.

@skjnldsv skjnldsv closed this as completed Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants