Create new Contact: Cannot read property 'displayName' of undefined

[benhartwich]

Steps to reproduce

1. Go to Contacts at Nextcloud 12 Beta 4.
2. Try to create a new contact.

Expected behaviour

A new contact input field should open up to create a new contact.

Actual behaviour

Nothing happens.

Server configuration

Operating system: Debian 8

Web server: nginx 1.10

Database: MariaDB 10.1

PHP version: 7

Nextcloud version: 12 Beta 4

Contacts version: 1.5.3

Updated from an older Nextcloud or fresh install: fresh install

Signing status:

No errors have been found.

List of activated apps:

  - activity: 2.5.2
  - admin_audit: 1.2.0
  - admin_notifications: 1.0.0
  - bruteforcesettings: 1.0.2
  - calendar: 1.5.2
  - circles: 0.9.6
  - comments: 1.2.0
  - contacts: 1.5.3
  - dav: 1.3.0
  - federatedfilesharing: 1.2.0
  - federation: 1.2.0
  - files: 1.7.2
  - files_accesscontrol: 1.2.3
  - files_automatedtagging: 1.2.2
  - files_markdown: 1.0.1
  - files_pdfviewer: 1.1.1
  - files_retention: 1.1.2
  - files_sharing: 1.4.0
  - files_texteditor: 2.4.1
  - files_trashbin: 1.2.0
  - files_versions: 1.5.0
  - files_videoplayer: 1.1.0
  - firstrunwizard: 2.1
  - gallery: 17.0.0
  - groupfolders: 1.0.2
  - logreader: 2.0.0
  - lookup_server_connector: 1.0.0
  - nextcloud_announcements: 1.1
  - notes: 2.2.0
  - notifications: 2.0.0
  - password_policy: 1.2.2
  - provisioning_api: 1.2.0
  - richdocuments: 1.1.26
  - serverinfo: 1.2.0
  - sharebymail: 1.2.0
  - socialsharing_diaspora: 1.0.1
  - socialsharing_email: 1.0.1
  - socialsharing_facebook: 1.0.1
  - socialsharing_googleplus: 1.0.1
  - socialsharing_twitter: 1.0.1
  - spreed: 2.0.0
  - survey_client: 1.0.0
  - systemtags: 1.2.0
  - theming: 1.3.0
  - twofactor_backupcodes: 1.1.1
  - twofactor_totp: 1.3.0
  - updatenotification: 1.2.0
  - workflowengine: 1.2.0

Nextcloud configuration:

{
    "system": {
        "instanceid": "ocilgvvs1r6q",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "beta.xy.de"
        ],
        "datadirectory": "\/var\/kunden\/nextcloud-beta\/httpdocs\/files",
        "overwrite.cli.url": "https:\/\/beta.xy.de",
        "dbtype": "mysql",
        "version": "12.0.0.21",
        "dbname": "nextcloud-beta",
        "dbhost": "localhost",
        "dbport": "",
        "dbtableprefix": "oc_",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "updater.release.channel": "beta",
        "mail_from_address": "mail",
        "mail_smtpmode": "php",
        "mail_smtpauthtype": "LOGIN",
        "mail_domain": "xy.de",
        "maintenance": false,
        "updater.secret": "***REMOVED SENSITIVE VALUE***",
        "theme": "",
        "loglevel": 2
    }
}

Are you using external storage, if yes which one: local

Are you using encryption: no

Are you using an external user-backend, if yes which one: no

Client configuration

Browser: Chrome

Operating system: Windows 7 64bit

CardDAV-clients:

Logs

Web server error log

Nothing relevant

Nextcloud log (data/nextcloud.log)

Error	PHP	Invalid argument supplied for foreach() at /var/kunden/nextcloud-beta/httpdocs/nextcloud/lib/private/AppConfig.php#296	2017-05-18T08:31:24+0200
Error	PHP	Undefined index: workflowengine at /var/kunden/nextcloud-beta/httpdocs/nextcloud/lib/private/AppConfig.php#296	2017-05-18T08:31:24+0200

Browser log

angular.js?v=6226036…-0:13920 TypeError: Cannot read property 'displayName' of undefined
    at new Contact (contact_model.js:12)
    at Object.create (contact_service.js:86)
    at Object.ctrl.createContact (newContactButton_controller.js:10)
    at fn (eval at compile (angular.js?v=6226036…-0:14817), <anonymous>:4:269)
    at expensiveCheckFn (angular.js?v=6226036…-0:15906)
    at callback (angular.js?v=6226036…-0:25885)
    at Scope.$eval (angular.js?v=6226036…-0:17682)
    at Scope.$apply (angular.js?v=6226036…-0:17782)
    at HTMLButtonElement.<anonymous> (angular.js?v=6226036…-0:25890)
    at HTMLButtonElement.dispatch (core.js?v=6226036…-0:3)

[irgendwie]

Thanks for your report! This error occurs, when no address book is available. The fix for this is 42d7a88 but it isn't contained in any release by now. We'll release a new version in the next days.

For now simply create a new address book in the settings menu and there shouldn't be any error anymore and the app should work.

Additionally, nextcloud/server contains code to automatically create a default address book (https://github.com/nextcloud/server/blob/master/apps/dav/lib/HookManager.php#L134-L142) still this seems to only happen for additional users and not the default admin user.

[thueske]

Can you give an update what "in the next days" mean? :) @irgendwie

[skjnldsv]

Ahaha, indeed this is coming pretty soon. The release is complete.