Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show vcard as qrcode #283

Closed
skjnldsv opened this issue Aug 9, 2017 · 17 comments
Closed

Show vcard as qrcode #283

skjnldsv opened this issue Aug 9, 2017 · 17 comments
Labels
enhancement New feature or request low Low priority
Milestone

Comments

@skjnldsv
Copy link
Member

skjnldsv commented Aug 9, 2017

We can easily convert a vcard as a qrcode for easy flash and save in smartphone.
What do you think @nextcloud/contacts, do you feel like this is a good idea?

Example:
qrcode

BEGIN:VCARD
VERSION:4.0
FN:Test 1
UID:dec8b591-ac52-437a-a9d1-060e714eb252
CATEGORIES:Group 1
END:VCARD

rel: https://www.npmjs.com/package/qrcode

@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of enhancement New feature or request labels Aug 9, 2017
@skjnldsv skjnldsv self-assigned this Aug 9, 2017
@skjnldsv skjnldsv added the low Low priority label Aug 28, 2017
@skjnldsv skjnldsv added this to the 2.1.0 milestone Aug 28, 2017
@jancborchardt
Copy link
Member

What’s the use-case here though? Nextcloud Contacts is all about syncing, so you already will have it in your phone?

Also, which phone contacts app has a QR code reader?

@jancborchardt jancborchardt removed the 1. to develop Accepted and waiting to be taken care of label Feb 27, 2018
@skjnldsv
Copy link
Member Author

@jancborchardt it was for quick share! :)
You just pop it up on your phone and add it to your contacts

@Matthias84
Copy link

Same here, this feature would be useful to share contacts with guests or strangers quickly and without creating accounts, ...

@creopard
Copy link

creopard commented May 10, 2018

It's a great idea, but it might not be necessary, as there are already phone apps that do all that on the fly.
(e.g.: https://play.google.com/store/apps/details?id=com.teacapps.barcodescanner and many more)
On the one hand these apps can create/display a QR code by sharing a contact via the app and on the other hand it can also scan a QR code and create a new contact automatically.

(I guess on most smartphones you would require an app to read QR codes at all...)

@jancborchardt
Copy link
Member

@skjnldsv I’d close this issue cause it’s more like a »we could do this thing« than »this is something we actually need«. Sharing contacts would be much simpler and more versatile by sharing a link.

@skjnldsv
Copy link
Member Author

skjnldsv commented Jun 5, 2018

@jancborchardt There is a loooot of enhancement requests on the contacts app, and I can't get myself to close them ^^

@skjnldsv skjnldsv removed their assignment Jun 5, 2018
@skjnldsv skjnldsv modified the milestones: 2.2.0, 3.1.0, 3.0.1 Oct 1, 2018
@skjnldsv skjnldsv modified the milestones: 3.0.1, 3.1.0 Dec 24, 2018
@j-ed
Copy link

j-ed commented Apr 3, 2019

@skjnldsv Does this feature depend on any function provided by the server? I've discovered this function after I installed one of your test versions (20190328), but it seems not to work yet on my server (NC v15.0.5)

@skjnldsv
Copy link
Member Author

skjnldsv commented Apr 3, 2019

@j-ed no, works from the app directly :)

@j-ed
Copy link

j-ed commented Apr 3, 2019

@skjnldsv That's weird. If I select that function on a contact only a white dot is shown on my server (NC v15.0.5 + FF v66.0.2):

grafik

@skjnldsv
Copy link
Member Author

skjnldsv commented Apr 3, 2019

@j-ed that's interesting :)
Any log in the browser console?

@j-ed
Copy link

j-ed commented Apr 3, 2019

If I select a contact the following messages are logged:

XHR - PROPFIND - https://<my-nextcloud-server>/remote.php/dav/addressbooks/users/<user>/Kontakte/1b3105f6-cdef-42e2-abc5-c752a4cc908b.vcf
[HTTP/2.0 207 Multi-Status 294ms]
ReferenceError: reference to undefined property "isdate" contacts.js:377:25934
ReferenceError: reference to undefined property "_tzm" contacts.js:377:23929
ReferenceError: reference to undefined property 2

If I select the Generate QR code function the following messages are logged:

ReferenceError: reference to undefined property 3 contacts.js:409:72621
ReferenceError: reference to undefined property "undefined" contacts.js:409:72376
ReferenceError: reference to undefined property "recognizers" contacts.js:135:11259
ReferenceError: reference to undefined property "enable" contacts.js:135:10524
ReferenceError: reference to undefined property 1 contacts.js:135:11710
port already set to: page

@skjnldsv
Copy link
Member Author

skjnldsv commented Apr 3, 2019

@j-ed those messages are not complete.
I would need the more detailed ones, you should have the ability to expand those errors, right?

I can also just create a debug release for you to try.
contacts.tar.gz

@j-ed
Copy link

j-ed commented Apr 3, 2019

@skjnldsv I've installed the app, updated the server configuration, cleared the browser cache and started testing the function again. Unfortunately it shows less information than before but the result is the same. To sum up my tests with different browsers:

  • Firefox 66.0.2 - only a dot is shown 😞
  • Microsoft Edge - a QR code is displayed. 👍
  • Vivaldi - a QR code is displayed. 👍

@skjnldsv
Copy link
Member Author

skjnldsv commented Apr 3, 2019

Unfortunately it shows less information than before

what do you mean by that? 🤔

@j-ed
Copy link

j-ed commented Apr 3, 2019

@skjnldsv With the release you provided I couldn't see reference errors anymore. Only the following messages are shown:

20190403_nc_contacts_app_qr_code_test

@skjnldsv
Copy link
Member Author

skjnldsv commented Apr 3, 2019

@j-ed thx! I fixed in on master!
It will be part of this week's release (3.1.0)

@j-ed
Copy link

j-ed commented Apr 3, 2019

@skjnldsv congrats! You're awesome 🥇

@skjnldsv skjnldsv modified the milestones: next minor, 3.1.0 Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low Low priority
Projects
None yet
Development

No branches or pull requests

5 participants