Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes not saved on Contacts #562

Closed
danicotillas opened this issue May 30, 2018 · 17 comments
Closed

Changes not saved on Contacts #562

danicotillas opened this issue May 30, 2018 · 17 comments

Comments

@danicotillas
Copy link

danicotillas commented May 30, 2018

Steps to reproduce

  1. I create a new contact or modify one
  2. It appears the message "Changes not saved"

Expected behaviour

The changes should be saved automatically

Actual behaviour

When I write a change or a new contact it simply doesn´t save on the records.

Server configuration

Are you using encryption: yes

Are you using an external user-backend, if yes which one: LDAP/ActiveDirectory/Webdav/...

Client configuration

Browser:
Chrome

Operating system:
MacOS

Browser log

Insert your browser log here, this could for example include:

a) Browser log

core.js?v=2d0ffb9a-15:7 JQMIGRATE: Migrate is installed, version 1.4.0
DevTools failed to parse SourceMap: https://caracol.nodocomun.org/core/vendor/purify.min.js.map
DevTools failed to parse SourceMap: https://caracol.nodocomun.org/apps/contacts/css/vendor/ui-select/select.min.css.map

@skjnldsv
Copy link
Member

Hey again :)
Can you screenshot your network request list after the message appear? (Open dev tools > network tab > there must be one request in red)

@skjnldsv skjnldsv added the needs info Not enough information provided label May 30, 2018
@danicotillas
Copy link
Author

danicotillas commented May 30, 2018

That? Sorry for my limited programming knowledge...

@skjnldsv
Copy link
Member

Perfect! Don't be sorry :)
Can you click on the 412 red request and copy the 'response' tab here please?

@danicotillas
Copy link
Author

danicotillas commented May 30, 2018

removed sensible data

@skjnldsv
Copy link
Member

@danicotillas sorry, There was too much sensible data. I edited your post.
I'm interested in the response tab visible after you clicked the failed request :)

@danicotillas
Copy link
Author

Oh, thanks! What would be the response tab exactly?

@skjnldsv
Copy link
Member

capture d ecran_2018-05-30_20-45-42

@danicotillas
Copy link
Author

<d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
<s:exception>Sabre\DAV\Exception\PreconditionFailed</s:exception>
<s:message>An If-Match header was specified, but none of the specified the ETags matched.</s:message>
<s:header>If-Match</s:header>
</d:error>

@skjnldsv
Copy link
Member

Okay, thanks! :)
Now, you seems to have one successful request before the faile done, can you copy me the requests headers? I'm interested in the two etag and oc-etag response

capture d ecran_2018-05-30_20-49-58

Also, I see you have an auto completion happening on your failed request, can I see the requets payload (you can edit the sensitive data like mail, phone, whataver) :)
capture d ecran_2018-05-30_20-51-40

@danicotillas
Copy link
Author

danicotillas commented May 30, 2018

if-match: null

BEGIN:VCARD
VERSION:3.0
FN:Raquel
UID:5e06bf89-13d6-490f-9bbd-ad64b5332ac0
REV:20180530T185448Z
EMAIL;TYPE=HOME:xxxxx@xxxx.com
CATEGORIES:Whatever
ORG:Whatever
TITLE:Whoever
END:VCARD

@skjnldsv
Copy link
Member

if-match: null

That's what I'm interested about, can you post the successful request headers (see my previous message) especially the etag and oc-etag part please.

@danicotillas
Copy link
Author

danicotillas commented May 30, 2018

A succesful one:

Request Method: PUT
Status Code: 204 
Referrer Policy: no-referrer
cache-control: no-store, no-cache, must-revalidate
content-security-policy: default-src 'none';
date: Wed, 30 May 2018 18:54:43 GMT
expires: Thu, 19 Nov 1981 08:52:00 GMT
host-header: 192fc2e7e50945beb8231a492d6a8024
oc-etag: "c0e08beebdbb19305de22ba6859a7f53"
pragma: no-cache
server: nginx
status: 204
vary: User-Agent
x-content-type-options: nosniff
x-download-options: noopen
x-frame-options: SAMEORIGIN
x-permitted-cross-domain-policies: none
x-robots-tag: none
x-xss-protection: 1; mode=block
:method: PUT

@skjnldsv
Copy link
Member

Amazing!
This is a duplicate of #257 Which has been fixed.
I need to publish a new release :)

Closing since it's fixed but not released

@danicotillas
Copy link
Author

So.... what should I do noW???

@skjnldsv
Copy link
Member

Wait for a new release of contacts! :)

@skjnldsv
Copy link
Member

skjnldsv commented Jun 1, 2018

@danicotillas New release published just for you ;)
Update when you'll get the notification that it's available to download :)

@skjnldsv skjnldsv removed the needs info Not enough information provided label Jun 1, 2018
@danicotillas
Copy link
Author

@skjnldsv Your heart doesn´t fit in your chest cause it´s so huge! Thanks a million!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants