Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] Design issues for addressbook sharing #600

Closed
4 tasks done
skjnldsv opened this issue Aug 28, 2018 · 4 comments
Closed
4 tasks done

[Vue] Design issues for addressbook sharing #600

skjnldsv opened this issue Aug 28, 2018 · 4 comments
Assignees
@sleepypioneer
Labels
1. to develop Accepted and waiting to be taken care of medium Medium priority
Milestone
3.0.0

Comments

@skjnldsv
Copy link
Member

skjnldsv commented Aug 28, 2018 •
edited by jospoortvliet
Loading

  • No cursor on delete icon
  • Checkbox design a bit off
  • No loading state
  • Clicking the share button directly focus the input
@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of vue labels Aug 28, 2018
@skjnldsv skjnldsv added this to the 3.0.0 milestone Aug 28, 2018
@skjnldsv skjnldsv changed the title [vue] Design issues for addressbook sharing [Vue] Design issues for addressbook sharing Aug 28, 2018
@nextcloud nextcloud deleted a comment from nextcloud-bot Aug 29, 2018
@sleepypioneer
Copy link
Member

Noted 👍

This was referenced Aug 29, 2018
Closed
Closed
@skjnldsv skjnldsv added the medium Medium priority label Aug 31, 2018
@sleepypioneer
Copy link
Member

sleepypioneer commented Aug 31, 2018 •
edited
Loading

@skjnldsv I have added the loading icon and the cursor Im not sure what about the checkbox other than the font weight we discussed is off, can you please look again and elaborate :) on branch https://github.com/nextcloud/contacts/tree/vue-design-issues-share-addressbook

@nextcloud-bot nextcloud-bot mentioned this issue Aug 31, 2018
Closed
13 tasks
@sleepypioneer sleepypioneer mentioned this issue Aug 31, 2018
Merged
@skjnldsv
Copy link
Member Author

Loading looks nice!!
Still this small dropdown showing before loading, which is annoying, but it's a nitpick ;)

I added one small great addtion to the top :) 👍

@sleepypioneer
Copy link
Member

Can you check again, I'm not sure I see the small drop down before loading. I am still unsure also about how the checkbox differs. Thank you 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleepypioneer sleepypioneer

Labels
1. to develop Accepted and waiting to be taken care of medium Medium priority
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@skjnldsv @sleepypioneer