Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select closest contact if any instead of going back to top on deletion #674

Closed
skjnldsv opened this issue Oct 24, 2018 · 2 comments
Closed

Select closest contact if any instead of going back to top on deletion #674

skjnldsv opened this issue Oct 24, 2018 · 2 comments
Labels
1. to develop Accepted and waiting to be taken care of good first issue Good for newcomers regression Regression of a previous working feature
Milestone
3.0.0

Comments

@skjnldsv
Copy link
Member

skjnldsv commented Oct 24, 2018 •
edited by jospoortvliet
Loading

When deleting, the first contact of the list gets selected.
We should instead select the closest contact to the one that got deleted
@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of good first issue Good for newcomers regression Regression of a previous working feature Hacktoberfest labels Oct 24, 2018
@skjnldsv skjnldsv added this to the 3.0.1 milestone Oct 24, 2018
@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #277 (Select multiple contacts), #296 (Contact deletion management), #638 ([Vue] Scroll to the selected contact), #376 (Store last selected Group and Contact), and #463 (Contacts with same name are selected incorrect in list).

@skjnldsv
Copy link
Member Author

Fixed in c0b2f31

@skjnldsv skjnldsv modified the milestones: 3.0.1, 3.0.0 Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop Accepted and waiting to be taken care of good first issue Good for newcomers regression Regression of a previous working feature
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@skjnldsv @nextcloud-bot