Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queue contacts updates #879

Merged
merged 2 commits into from
Jan 24, 2019
Merged

Queue contacts updates #879

merged 2 commits into from
Jan 24, 2019

Conversation

skjnldsv
Copy link
Member

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug Something isn't working 2. developing Work in progress high High priority labels Jan 23, 2019
@skjnldsv skjnldsv added this to the next milestone Jan 23, 2019
@skjnldsv skjnldsv self-assigned this Jan 23, 2019
@codecov
Copy link

codecov bot commented Jan 23, 2019

Codecov Report

Merging #879 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #879   +/-   ##
=======================================
  Coverage   64.91%   64.91%           
=======================================
  Files           4        4           
  Lines          57       57           
=======================================
  Hits           37       37           
  Misses         20       20

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0af418...eae3c15. Read the comment docs.

Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke georgehrke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 24, 2019
@skjnldsv skjnldsv merged commit 9b3d292 into master Jan 24, 2019
@skjnldsv skjnldsv deleted the queue-request branch January 24, 2019 11:38
@georgehrke
Copy link
Member

@Ningappa How did you test this? This fix wasn't released in a stable version yet.

@binaryhq
Copy link

@georgehrke comment is specific to this commit.
I've installed test nextcloud locally. I do watch daily commits of contact app and I take those changes to local. I hope I'm not doing anything wrong.

@skjnldsv
Copy link
Member Author

@Ningappa have you cleared your cache?

@binaryhq
Copy link

@skjnldsv I changed bit of webpack common configuration file. Everytime i build, it create new file with hash in the filename and i used find-replace-webpack-plugin to generate dynamic main.php . So there is no need of clear cache since every build loads new application js file to the application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working high High priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants