Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use localContact to detect changes #968

Merged
merged 1 commit into from
Mar 4, 2019
Merged

Use localContact to detect changes #968

merged 1 commit into from
Mar 4, 2019

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Mar 4, 2019

Fix #923

@skjnldsv
Use localContact to detect changes
60b0708 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews labels Mar 4, 2019
@skjnldsv skjnldsv added this to the next milestone Mar 4, 2019
@skjnldsv skjnldsv self-assigned this Mar 4, 2019
@codecov
Copy link

codecov bot commented Mar 4, 2019

Codecov Report

Merging #968 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #968   +/-   ##
=======================================
  Coverage   55.88%   55.88%           
=======================================
  Files           4        4           
  Lines          68       68           
=======================================
  Hits           38       38           
  Misses         30       30

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd33df7...60b0708. Read the comment docs.

@skjnldsv skjnldsv merged commit f42acff into master Mar 4, 2019
@skjnldsv skjnldsv deleted the fix/localcontact/value-watcher-update branch March 4, 2019 09:40
@skjnldsv skjnldsv mentioned this pull request Mar 4, 2019
Closed
@skjnldsv skjnldsv modified the milestones: next, 3.0.4 Mar 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Milestone
3.0.4
Development

Successfully merging this pull request may close these issues.
1 participant
@skjnldsv