Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the work profile the default one when adding Contacts #1307

Merged
merged 6 commits into from
Oct 22, 2019
Merged

Make the work profile the default one when adding Contacts #1307

merged 6 commits into from
Oct 22, 2019

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Oct 17, 2019

No description provided.

@GretaD
Make the work profile the default one when adding Contacts
3f76420 
Signed-off-by: Greta Doci <gretadoci@gmail.com>
@GretaD GretaD added the 3. to review Waiting for reviews label Oct 17, 2019
@GretaD
fix test
469a3fd 
Signed-off-by: Greta Doci <gretadoci@gmail.com>
@GretaD GretaD requested a review from nickvergessen October 17, 2019 12:40
@codecov
Copy link

codecov bot commented Oct 17, 2019 •
edited
Loading

Codecov Report

Merging #1307 into master will increase coverage by 2%.
The diff coverage is 85.71%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1307   +/-   ##
=======================================
+ Coverage   60.31%   62.31%   +2%     
=======================================
  Files           4        4           
  Lines          63       69    +6     
=======================================
+ Hits           38       43    +5     
- Misses         25       26    +1
Impacted Files Coverage Δ
lib/Controller/PageController.php 80% <85.71%> (+2.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e94a58d...bb11ed7. Read the comment docs.

skjnldsv
skjnldsv approved these changes Oct 17, 2019
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from one comment, code looks good :)

GretaD added 2 commits October 17, 2019 18:29
@GretaD
Make the work profile the default one when adding Contacts
99ae1bc 
We need to split the default state in order for the user to decide
which one should be default for them depending wethers if its a
enterpirse solution or not

Signed-off-by: Greta Doci <gretadoci@gmail.com>
@GretaD
Fix spaces
cd2e1ed 
Signed-off-by: Greta Doci <gretadoci@gmail.com>
@skjnldsv skjnldsv requested review from nickvergessen and removed request for nickvergessen October 18, 2019 09:26
@nickvergessen
Copy link
Member

Phone is still defaulting to HOME

contacts/src/models/rfcProps.js

Lines 185 to 188 in cd2e1ed

defaultValue: {
value: '',
type: ['HOME', 'VOICE']
},

@GretaD
change defaultValue for tel
5e1b414 
Signed-off-by: Greta Doci <gretadoci@gmail.com>
@GretaD
fix tel type
bb11ed7 
Signed-off-by: Greta Doci <gretadoci@gmail.com>
@GretaD GretaD requested a review from nickvergessen October 21, 2019 14:51
@nickvergessen nickvergessen merged commit 2822acf into master Oct 22, 2019
@welcome
Copy link

welcome bot commented Oct 22, 2019

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/contacts/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Most developers hang out on IRC. So join #nextcloud-contacts and #nextcloud-dev on Freenode for a chat!

@delete-merged-branch delete-merged-branch bot deleted the feature/228/default_work_profile branch October 22, 2019 09:00
@GretaD GretaD restored the feature/228/default_work_profile branch November 5, 2019 14:57
@GretaD GretaD deleted the feature/228/default_work_profile branch November 5, 2019 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GretaD @nickvergessen @skjnldsv