Remove delete action from list, fix #1368

[jancborchardt]

Simply removes the delete icons in the contact list as mentioned by the issue at #1368 and illustrated in the screenshot. :)

Deleting a contact is still possibly through the 3-dot menu in the detail view.

Please review @skjnldsv @hanzi @ralxxx

[codecov]

Codecov Report

Merging #1430 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1430   +/-   ##
=======================================
  Coverage   62.31%   62.31%           
=======================================
  Files           4        4           
  Lines          69       69           
=======================================
  Hits           43       43           
  Misses         26       26

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32a7d9d...ee31758. Read the comment docs.

[hanzi]

I like it in principle. That delete button wasn't really necessary there.

But I'm a bit worried that the delete button might be hidden away a bit too much now. That 3-dot menu is far away from everything else. Not sure if it's that obvious to find.

The Mail app (which has the same layout structure) has a second instance of the 3-dot menu in the mail list. Maybe that's an option for Contacts as well?

[hanzi]

Another thing: There's still some related CSS code in css/ContactsListItem.scss which should also be removed.

[jancborchardt]

Another thing: There's still some related CSS code in css/ContactsListItem.scss which should also be removed.

Thanks for the catch – fixed. :)

But I'm a bit worried that the delete button might be hidden away a bit too much now. That 3-dot menu is far away from everything else. Not sure if it's that obvious to find.

Agree that the 3-dot-menu is too far away. This is caused by the fact that we go wide into oblivion. We should also restrict the width, just like we do for Mail (
nextcloud/mail#2180 ) and Talk.
But this is something for a separate pull request. :)

The Mail app (which has the same layout structure) has a second instance of the 3-dot menu in the mail list. Maybe that's an option for Contacts as well?

While it has the same layout, the big difference between Mail and Contacts is that Mail is an active app – you are likely in there every day, and working a lot with the entries. Contacts is more of a passive app, where you edit stuff once in a while, and don’t delete as often as you do mails. So I’d say there’s no need for the 3-dot menu in the contact list.

[hanzi]

While it has the same layout, the big difference between Mail and Contacts is that Mail is an active app – you are likely in there every day, and working a lot with the entries. Contacts is more of a passive app, where you edit stuff once in a while, and don’t delete as often as you do mails. So I’d say there’s no need for the 3-dot menu in the contact list.

Valid point, but personally I'd be in favour of having consistent patterns across theses apps. If it looks the same, it should work the same.

But you're right, this is probably better suited as a task of its own.