Simplify form #1446

jancborchardt · 2020-01-28T04:00:35Z

Hide delete icons initially to not overflow interface
Remove unneeded info icons and tooltips
Work in progress of placeholders for social profiles

Need help on displaying placeholders for social profiles, see also #1445

codecov · 2020-01-28T04:08:05Z

Codecov Report

Merging #1446 into master will decrease coverage by 33.09%.
The diff coverage is 22.97%.

@@              Coverage Diff              @@
##             master    #1446       +/-   ##
=============================================
- Coverage     67.16%   34.06%   -33.10%     
- Complexity       15       99       +84     
=============================================
  Files             5       14        +9     
  Lines            67      273      +206     
=============================================
+ Hits             45       93       +48     
- Misses           22      180      +158

Impacted Files	Coverage Δ	Complexity Δ
appinfo/app.php	`0.00% <ø> (ø)`	`0.00 <0.00> (ø)`
appinfo/routes.php	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
lib/AppInfo/Application.php	`0.00% <ø> (ø)`	`1.00 <0.00> (-1.00)`
lib/Controller/SocialApiController.php	`0.00% <0.00%> (ø)`	`5.00 <5.00> (?)`
lib/Service/Social/CompositeSocialProvider.php	`0.00% <0.00%> (ø)`	`10.00 <10.00> (?)`
lib/Service/Social/FacebookProvider.php	`0.00% <0.00%> (ø)`	`10.00 <10.00> (?)`
lib/Service/Social/InstagramProvider.php	`0.00% <0.00%> (ø)`	`9.00 <9.00> (?)`
lib/Service/Social/MastodonProvider.php	`0.00% <0.00%> (ø)`	`9.00 <9.00> (?)`
lib/Service/Social/TumblrProvider.php	`0.00% <0.00%> (ø)`	`6.00 <6.00> (?)`
lib/Service/Social/TwitterProvider.php	`0.00% <0.00%> (ø)`	`11.00 <11.00> (?)`
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9efb9d2...ea399a4. Read the comment docs.

jancborchardt · 2020-02-27T15:55:19Z

I need help for the last part :)

Need help on displaying placeholders for social profiles, see also #1445

src/models/rfcProps.js

jancborchardt · 2020-04-22T22:52:09Z

Ready to review now! :)

If someone wants to help with the "displaying placeholders for social profiles, see also #1445" you are welcome, otherwise I think we can also finish this in a follow-up.

skjnldsv · 2020-04-23T05:38:38Z

Screenshots?

skjnldsv · 2020-04-23T05:40:24Z

src/components/Properties/PropertyTitle.vue

-		<span class="property__value property__title--right">
-			<div>{{ readableName }}</div>
-			<!-- display tooltip with hint if available -->
-			<div v-if="info" v-tooltip.auto="info" class="property__title--icon-details icon-details" />


I still disagree with this.
We had to add this because lots of users are confused and vCards is complicated.
I don't want to remove it and I think it doesn't create any issues to leave it there

Did you ever see something like this in another popular Contacts app?

Let's ask the question differently, what would you say to a user that says they doesn't understand the difference between RELATED & RELATIONSHIP ? :)

To that I would say that I fixed the wording via 715df61
→ to 'Relationship to you' and 'Related contacts'

;)

Is it more clear? Doesn't really seems to me 🙈

Yes, it’s quite clear. One thing is to put in the "Relationship to you" andthe other thing is to put in "Related contacts". Not sure how much clearer it can be.

Sure, your call!

skjnldsv

contacts/css/Properties/PropertyTitle.scss

Line 37 in feff0c7

.property__title--icon-details {

to cleanup as well

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>

jancborchardt · 2020-06-06T23:04:14Z

Fixed your feedback @skjnldsv and rebased as well, ready to review @nextcloud/contacts. :)

jancborchardt · 2020-07-29T13:26:38Z

@skjnldsv not sure about the waiting reports, they don’t seem to come back? Want to merge? :)

skjnldsv · 2020-07-29T13:36:24Z

That should trigger it again :)

call-me-matt · 2020-07-30T21:49:16Z

src/models/rfcProps.js

+			{ id: 'FACEBOOK', name: 'Facebook', placeholder: 'https://facebook.com/…' },
+			{ id: 'GITHUB', name: 'GitHub', placeholder: 'https://github.com/…' },
+			{ id: 'GOOGLEPLUS', name: 'Google+', placeholder: 'https://plus.google.com/…' },
+			{ id: 'INSTAGRAM', name: 'Instagram', placeholder: 'https://instagram.com/…' },
+			{ id: 'LINKEDIN', name: 'LinkedIn', placeholder: 'https://linkedin.com/…' },
+			{ id: 'PINTEREST', name: 'Pinterest', placeholder: 'https://pinterest.com/…' },
+			{ id: 'QZONE', name: 'QZone', placeholder: 'https://qzone.com/…' },
+			{ id: 'TUMBLR', name: 'Tumblr', placeholder: 'https://tumblr.com/…' },
+			{ id: 'TWITTER', name: 'Twitter', placeholder: 'https://twitter.com/…' },
+			{ id: 'WECHAT', name: 'WeChat', placeholder: 'https://wechat.com/…' },
+			{ id: 'YOUTUBE', name: 'YouTube', placeholder: 'https://youtube.com/…' },
+			{ id: 'MASTODON', name: 'Mastodon', placeholder: 'https://mastodon.social/…' },
+			{ id: 'DIASPORA', name: 'Diaspora', placeholder: 'https://joindiaspora.com/…' },
+			{ id: 'OTHER', name: 'Other social media', placeholder: 'https://example.com/…' },


The placeholders did not show up when I tried it out? It's still work in progress, right?

And because you asked: I find it easier to read when only the username is stored, not the URL. In my point of view that is redundant information to the type and just fills up the complete textfield.

call-me-matt · 2020-07-30T22:22:52Z

What do you think about hiding the date picker in the same way we hide the trashcan?

jancborchardt · 2020-08-21T10:18:54Z

Yep @call-me-matt, agree with both your points. :) I'd say in the interest of small steps, we should merge this and do those in separate pull requests though?

Especially as only showing the username instead of full URL will need some backend stuff, and ppl might have put in urls with https or http, with or without "www.", with or without "mobile." (in the case of Twitter).

call-me-matt · 2020-08-21T10:50:43Z

Especially as only showing the username instead of full URL will need some backend stuff, and ppl might have put in urls with https or http, with or without "www.", with or without "mobile." (in the case of Twitter).

I think that is not too difficult to implement. For the avatar download I have already done that for most use cases. Usually its only the basename-function that is required :)

jancborchardt added enhancement New feature or request help wanted Extra attention is needed 2. developing Work in progress design Related to the design labels Jan 28, 2020

jancborchardt requested review from skjnldsv, myrho and suntala February 27, 2020 15:54

skjnldsv reviewed Feb 27, 2020

View reviewed changes

src/models/rfcProps.js Show resolved Hide resolved

jancborchardt mentioned this pull request Apr 22, 2020

Remove header color bar as it is not related to the contact #1447

Merged

jancborchardt force-pushed the design/form-simplifyy branch from 80e11eb to 2b213c6 Compare April 22, 2020 21:40

jancborchardt requested a review from skjnldsv April 22, 2020 22:47

jancborchardt added 3. to review Waiting for reviews and removed 2. developing Work in progress help wanted Extra attention is needed labels Apr 22, 2020

jancborchardt requested a review from call-me-matt April 22, 2020 22:48

jancborchardt marked this pull request as ready for review April 22, 2020 22:51

jancborchardt requested a review from ImUrX April 22, 2020 22:51

skjnldsv requested changes Apr 23, 2020

View reviewed changes

skjnldsv requested changes May 7, 2020

View reviewed changes

jancborchardt added 6 commits June 7, 2020 01:00

Hide delete icons initially to not overflow interface

c70bfe5

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>

Remove unneeded info icons and tooltips

213ca55

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>

Work in progress of placeholders for social profiles

33f4655

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>

Fix action icons so they show on full row hover

b921ebb

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>

Un-de-emphasize h3 for better structure

a5b6b97

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>

Clarify wording of 'Relationship to you' and 'Related contacts'

d2d1062

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>

jancborchardt force-pushed the design/form-simplifyy branch from 715df61 to d2d1062 Compare June 6, 2020 23:01

Clean up unneeded CSS

ea399a4

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>

jancborchardt requested a review from skjnldsv June 6, 2020 23:03

skjnldsv approved these changes Jul 4, 2020

View reviewed changes

skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 4, 2020

skjnldsv closed this Jul 29, 2020

skjnldsv reopened this Jul 29, 2020

call-me-matt reviewed Jul 30, 2020

View reviewed changes

skjnldsv merged commit 4291725 into master Aug 21, 2020

skjnldsv deleted the design/form-simplifyy branch August 21, 2020 10:19

skjnldsv added this to the 3.4.0 milestone Oct 1, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Simplify form #1446

Simplify form #1446

jancborchardt commented Jan 28, 2020

codecov bot commented Jan 28, 2020 •

edited

Loading

jancborchardt commented Feb 27, 2020

jancborchardt commented Apr 22, 2020

skjnldsv commented Apr 23, 2020

skjnldsv Apr 23, 2020

jancborchardt May 6, 2020

skjnldsv May 6, 2020

jancborchardt May 6, 2020

skjnldsv May 6, 2020

jancborchardt May 6, 2020

skjnldsv May 7, 2020

skjnldsv left a comment

jancborchardt commented Jun 6, 2020

jancborchardt commented Jul 29, 2020

skjnldsv commented Jul 29, 2020

call-me-matt Jul 30, 2020 •

edited

Loading

call-me-matt commented Jul 30, 2020

jancborchardt commented Aug 21, 2020

call-me-matt commented Aug 21, 2020

Simplify form #1446

Simplify form #1446

Conversation

jancborchardt commented Jan 28, 2020

codecov bot commented Jan 28, 2020 • edited Loading

Codecov Report

jancborchardt commented Feb 27, 2020

jancborchardt commented Apr 22, 2020

skjnldsv commented Apr 23, 2020

skjnldsv Apr 23, 2020

Choose a reason for hiding this comment

jancborchardt May 6, 2020

Choose a reason for hiding this comment

skjnldsv May 6, 2020

Choose a reason for hiding this comment

jancborchardt May 6, 2020

Choose a reason for hiding this comment

skjnldsv May 6, 2020

Choose a reason for hiding this comment

jancborchardt May 6, 2020

Choose a reason for hiding this comment

skjnldsv May 7, 2020

Choose a reason for hiding this comment

skjnldsv left a comment

Choose a reason for hiding this comment

jancborchardt commented Jun 6, 2020

jancborchardt commented Jul 29, 2020

skjnldsv commented Jul 29, 2020

call-me-matt Jul 30, 2020 • edited Loading

Choose a reason for hiding this comment

call-me-matt commented Jul 30, 2020

jancborchardt commented Aug 21, 2020

call-me-matt commented Aug 21, 2020

codecov bot commented Jan 28, 2020 •

edited

Loading

call-me-matt Jul 30, 2020 •

edited

Loading