Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to clone contact #1462

Merged
merged 1 commit into from
Apr 1, 2020
Merged

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Feb 4, 2020

Capture d’écran_2020-02-04_16-26-58

If addressbook is readonly, we should be able to import into another available addressbook

  • UI
  • Clone methods
  • 1 avail. addressbook
  • Select if more than 1 avail.

@skjnldsv skjnldsv added enhancement New feature or request 2. developing Work in progress labels Feb 4, 2020
@skjnldsv skjnldsv added this to the next minor milestone Feb 4, 2020
@skjnldsv skjnldsv self-assigned this Feb 4, 2020
const newContact = new Contact(vData, addressbook)

try {
const response = await contact.dav.copy(addressbook.dav)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use contact.addressbook.dav.createVCard(vData) instead to force a different filename and avoid conflicts

@skjnldsv skjnldsv requested review from hanzi, rullzer and blizzz February 4, 2020 15:36
@codecov
Copy link

codecov bot commented Feb 4, 2020

Codecov Report

Merging #1462 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1462   +/-   ##
=========================================
  Coverage     75.43%   75.43%           
  Complexity       13       13           
=========================================
  Files             4        4           
  Lines            57       57           
=========================================
  Hits             43       43           
  Misses           14       14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d41416...02de7d7. Read the comment docs.

@skjnldsv skjnldsv force-pushed the enhancement/add-clone-option branch from 903819e to 1819d6f Compare February 6, 2020 10:40
@skjnldsv skjnldsv marked this pull request as ready for review March 11, 2020 07:37
@skjnldsv skjnldsv force-pushed the enhancement/add-clone-option branch from 1819d6f to 5d06718 Compare March 12, 2020 08:04
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the enhancement/add-clone-option branch from 5d06718 to 02de7d7 Compare March 13, 2020 11:14
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 16, 2020
@skjnldsv skjnldsv merged commit b47082b into master Apr 1, 2020
@skjnldsv skjnldsv deleted the enhancement/add-clone-option branch April 1, 2020 11:08
@rubo77
Copy link

rubo77 commented Apr 17, 2020

I updated my Contacts to 3.3.0 but in the 3-dot -menu I only see download, QR and delete options.

I am on NC 18.0.3.

I have those open problems:

MySQL is used as database but does not support 4-byte characters. To be able to handle 4-byte characters (like emojis) without issues in filenames or comments for example it is recommended to enable the 4-byte support in MySQL. For further details read the documentation page about this.
The "X-Download-Options" HTTP header is not set to "noopen". This is a potential security or privacy risk, as it is recommended to adjust this setting accordingly.

but I guess, that's not the reason for the missing copy-option?

How do I get this feature?

@skjnldsv
Copy link
Member Author

Hey!
The clone functionality is only hear when the contact is in read only :)
Do you have a specific use for it to be copied somewhere else?

We had a specific use case in mind, but I guess we could show the option all the time 🤔

@rubo77
Copy link

rubo77 commented Apr 17, 2020

The clone functionality is only hear when the contact is in read only

How do you set a contact to read-only?

Yes, the option should be there for all contacts

@skjnldsv skjnldsv modified the milestones: next minor, next Sep 6, 2020
@skjnldsv skjnldsv modified the milestones: next, 3.4.0 Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants