-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to clone contact #1462
Conversation
const newContact = new Contact(vData, addressbook) | ||
|
||
try { | ||
const response = await contact.dav.copy(addressbook.dav) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use contact.addressbook.dav.createVCard(vData) instead to force a different filename and avoid conflicts
Codecov Report
@@ Coverage Diff @@
## master #1462 +/- ##
=========================================
Coverage 75.43% 75.43%
Complexity 13 13
=========================================
Files 4 4
Lines 57 57
=========================================
Hits 43 43
Misses 14 14 Continue to review full report at Codecov.
|
903819e
to
1819d6f
Compare
1819d6f
to
5d06718
Compare
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
5d06718
to
02de7d7
Compare
I updated my Contacts to 3.3.0 but in the 3-dot -menu I only see download, QR and delete options. I am on NC 18.0.3. I have those open problems:
but I guess, that's not the reason for the missing copy-option? How do I get this feature? |
Hey! We had a specific use case in mind, but I guess we could show the option all the time 🤔 |
How do you set a contact to read-only? Yes, the option should be there for all contacts |
If addressbook is readonly, we should be able to import into another available addressbook