Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to get direct contact route #1730

Merged
merged 1 commit into from
Aug 3, 2020
Merged

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Aug 3, 2020

https://dev.domain.com/apps/contacts/direct/8588f5b7-19ec-47d0-9bbe-58b04e0ccf18~contacts

@skjnldsv skjnldsv added enhancement New feature or request 3. to review Waiting for reviews labels Aug 3, 2020
@skjnldsv skjnldsv added this to the next milestone Aug 3, 2020
@skjnldsv skjnldsv requested a review from georgehrke August 3, 2020 09:39
@skjnldsv skjnldsv self-assigned this Aug 3, 2020
@skjnldsv skjnldsv force-pushed the enh/contact-direct-route branch from 2c401a8 to a2b49ab Compare August 3, 2020 09:41
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 3, 2020
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the enh/contact-direct-route branch from a2b49ab to fd91fab Compare August 3, 2020 10:05
@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #1730 into master will increase coverage by 1.29%.
The diff coverage is 94.11%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1730      +/-   ##
============================================
+ Coverage     34.06%   35.35%   +1.29%     
- Complexity       99      101       +2     
============================================
  Files            14       15       +1     
  Lines           273      280       +7     
============================================
+ Hits             93       99       +6     
- Misses          180      181       +1     
Impacted Files Coverage Δ Complexity Δ
appinfo/routes.php 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
lib/Controller/ContactsController.php 100.00% <100.00%> (ø) 2.00 <2.00> (?)
lib/Controller/PageController.php 100.00% <100.00%> (ø) 2.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c17a3ea...fd91fab. Read the comment docs.

@skjnldsv skjnldsv merged commit 9d65ef5 into master Aug 3, 2020
@skjnldsv skjnldsv deleted the enh/contact-direct-route branch August 3, 2020 10:15
@skjnldsv skjnldsv modified the milestones: next, 3.4.0 Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants