more robust social ids for social sync #1843
Conversation
call-me-matt
commented
Oct 10, 2020
•
call-me-matt
commented
- resolve facebook-id from usernames
- accept mastodon userids without leading 'at'
- ignore apple markers as in Remove quotes from TYPE for better external platforms compatibility #1107 (comment)
Codecov Report
@@ Coverage Diff @@
## master #1843 +/- ##
=========================================
Coverage ? 37.02%
Complexity ? 160
=========================================
Files ? 19
Lines ? 497
Branches ? 0
=========================================
Hits ? 184
Misses ? 313
Partials ? 0
Continue to review full report at Codecov.
|
|
iOS adds an
Nextcloud interprets it like this: If the format from apple is acceptable, this PR filters out the additional |
call-me-matt
added
0. Needs triage
2. developing
call-me-matt
changed the title
| @@ -35,6 +35,7 @@ public function __construct() { | |||
| * @return string | |||
| */ | |||
| public function cleanupId(string $candidate):?string { | |||
| $candidate = preg_replace('/^' . preg_quote('x-apple:', '/') . '/', '', $candidate); | |||
There was a problem hiding this comment.
Maybe this should go into the level above so $candidate is already sanitized?
There was a problem hiding this comment.
There was a problem hiding this comment.
Sure, it can be there, too. But apple only attaches this to custom fields. For certain networks (for example Facebook and Twitter) it adds the domain of the service and no x-apple. So because it is not valid for all networks, I only added it where necessary. I'll let you decide where it's best.
There was a problem hiding this comment.
Well, I guess it's easier to have it once and for all rather than on every provider?
Maybe I'm missing something 🤔 😉
There was a problem hiding this comment.
just to be clear: we do not need it for every provider. apple only adds this "x-apple" thingy to the networks it does not know. All pre-defined networks (in the iOS-contacts-app) don't have that tag. So I thought its more a temporary thing and it can be removed time after time from the known networks.
call-me-matt
force-pushed
the
fix/social-apple
branch
from
fdfd7da to
f5214be
Compare
|
big news: I found a better way to get the profile id from facebook for any profile! It works very nicely (until fb changes their site...) |
call-me-matt
force-pushed
the
fix/social-apple
branch
from
f5214be to
be213fb
Compare
- get facebook id from usernames - accept mastodon usernames without leading at - ignore iOS marker as in 1107#issuecomment-706518724 Signed-off-by: call-me-matt <nextcloud@matthiasheinisch.de>
call-me-matt
force-pushed
the
fix/social-apple
branch
from
be213fb to
e3814b7
Compare
skjnldsv
added
3. to review
