Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix avatar display on read-only contacts and use global Avatar component #1846

Merged
merged 1 commit into from
Oct 20, 2020

Conversation

skjnldsv
Copy link
Member

Before After
Kazam_screenshot_00004 Kazam_screenshot_00003

@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews design Related to the design labels Oct 12, 2020
@skjnldsv skjnldsv added this to the next milestone Oct 12, 2020
@skjnldsv skjnldsv self-assigned this Oct 12, 2020
@codecov

This comment has been minimized.

Copy link
Member

@call-me-matt call-me-matt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice!
Unfortunately I cannot change the avatar anymore:

console error
Error: 
    r dist.js:1
    r dist.js:1
    o dist.js:1
    t dist.js:1
    n dist.js:1
    onreadystatechange dist.js:1
    e dist.js:1
    e dist.js:1
    l dist.js:1
    _invoke dist.js:1
    v dist.js:1
    me dist.js:1
    i dist.js:1
    de dist.js:1
    de dist.js:1
    value dist.js:1
    e dist.js:1
    l dist.js:1
    _invoke dist.js:1
    v dist.js:1
    me dist.js:1
    i dist.js:1
    de dist.js:1
    de dist.js:1
    value dist.js:1
    e dist.js:1
    l dist.js:1
    _invoke dist.js:1
    v dist.js:1
    ke dist.js:1
    i dist.js:1
    Se dist.js:1
    Se dist.js:1
    value dist.js:1
    n contacts.js:349
    l dist.js:1
    _invoke dist.js:1
    v dist.js:1
    Yn contacts-main.js:1586
    i contacts-main.js:1586
    Gn contacts-main.js:1586
    Gn contacts-main.js:1586
    updateContact contacts.js:325
    f vuex.esm.js:847
    dispatch vuex.esm.js:512
    dispatch vuex.esm.js:402
    setPhoto ContactDetailsAvatar.vue:342
    e ContactDetailsAvatar.vue:255
    l dist.js:1
    _invoke dist.js:1
    v dist.js:1
    T contacts-main.js:600
    i contacts-main.js:600
    E contacts-main.js:600
    E contacts-main.js:600
    onloadend ContactDetailsAvatar.vue:223
    processFile ContactDetailsAvatar.vue:223
    VueJS 3
contacts.js:353:12
    n contacts.js:353
    l dist.js:1
    _invoke dist.js:1
    v dist.js:1
    Yn contacts-main.js:1586
    a contacts-main.js:1586
    (Async: promise callback)
    Yn contacts-main.js:1586
    i contacts-main.js:1586
    Gn contacts-main.js:1586
    Gn contacts-main.js:1586
    updateContact contacts.js:325
    f vuex.esm.js:847
    dispatch vuex.esm.js:512
    dispatch vuex.esm.js:402
    setPhoto ContactDetailsAvatar.vue:342
    e ContactDetailsAvatar.vue:255
    l dist.js:1
    _invoke dist.js:1
    v dist.js:1
    T contacts-main.js:600
    i contacts-main.js:600
    E contacts-main.js:600
    E contacts-main.js:600
    onloadend ContactDetailsAvatar.vue:223
    (Async: EventHandlerNonNull)
    processFile ContactDetailsAvatar.vue:223
    VueJS 3
        Ye
        n
        _wrapper

EDIT: I can change the avatar, but it's not displayed.

@skjnldsv

This comment has been minimized.

@call-me-matt

This comment has been minimized.

@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Oct 13, 2020
@skjnldsv skjnldsv mentioned this pull request Oct 15, 2020
@skjnldsv skjnldsv removed the 2. developing Work in progress label Oct 19, 2020
@skjnldsv skjnldsv requested a review from call-me-matt October 19, 2020 06:48
@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Oct 19, 2020
@skjnldsv
Copy link
Member Author

Done :)

@skjnldsv skjnldsv requested a review from jakobroehrl October 19, 2020 10:02
@call-me-matt
Copy link
Member

Almost perfect. Only in the list view of the person I share my contacts with, the avatars are either not shown or blanked out. In the details-header, the avatar is shown correctly. No error logs beside The following contact has been repaired: invalid REV

@skjnldsv
Copy link
Member Author

Only in the list view of the person I share my contacts with, the avatars are either not shown or blanked out.

So as UserA, you share an addressbook with UserB and UserB cannot see avatars in the list?
Can you inspect the html of the Avatar in the list and copy/paste it here?

@call-me-matt
Copy link
Member

call-me-matt commented Oct 19, 2020

So as UserA, you share an addressbook with UserB and UserB cannot see avatars in the list?

Unfortunately yes.

Can you inspect the html of the Avatar in the list and copy/paste it here?

  1. At first loading, all avatars (in the list) are letters:
    Bildschirmfoto von 2020-10-19 22-22-05

  2. once clicked Mr. Test turns white
    Bildschirmfoto von 2020-10-19 22-22-38

  3. while Mr Hello remains a letter.
    Bildschirmfoto von 2020-10-19 22-23-01

(if I remove the dot an rename Mr. Test to Mr Test, he behaves just like Mr Hello)

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Copy link
Member Author

Fixed @call-me-matt ! :)

Copy link
Member

@call-me-matt call-me-matt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful.
APPROVED.

@skjnldsv skjnldsv merged commit c3f8056 into master Oct 20, 2020
@skjnldsv skjnldsv deleted the fix/avatar branch October 20, 2020 18:38
@skjnldsv skjnldsv removed this from the next milestone Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working design Related to the design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants