-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix avatar display on read-only contacts and use global Avatar component #1846
Conversation
skjnldsv
commented
Oct 12, 2020
Before | After |
---|---|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very nice!
Unfortunately I cannot change the avatar anymore:
console error
Error:
r dist.js:1
r dist.js:1
o dist.js:1
t dist.js:1
n dist.js:1
onreadystatechange dist.js:1
e dist.js:1
e dist.js:1
l dist.js:1
_invoke dist.js:1
v dist.js:1
me dist.js:1
i dist.js:1
de dist.js:1
de dist.js:1
value dist.js:1
e dist.js:1
l dist.js:1
_invoke dist.js:1
v dist.js:1
me dist.js:1
i dist.js:1
de dist.js:1
de dist.js:1
value dist.js:1
e dist.js:1
l dist.js:1
_invoke dist.js:1
v dist.js:1
ke dist.js:1
i dist.js:1
Se dist.js:1
Se dist.js:1
value dist.js:1
n contacts.js:349
l dist.js:1
_invoke dist.js:1
v dist.js:1
Yn contacts-main.js:1586
i contacts-main.js:1586
Gn contacts-main.js:1586
Gn contacts-main.js:1586
updateContact contacts.js:325
f vuex.esm.js:847
dispatch vuex.esm.js:512
dispatch vuex.esm.js:402
setPhoto ContactDetailsAvatar.vue:342
e ContactDetailsAvatar.vue:255
l dist.js:1
_invoke dist.js:1
v dist.js:1
T contacts-main.js:600
i contacts-main.js:600
E contacts-main.js:600
E contacts-main.js:600
onloadend ContactDetailsAvatar.vue:223
processFile ContactDetailsAvatar.vue:223
VueJS 3
contacts.js:353:12
n contacts.js:353
l dist.js:1
_invoke dist.js:1
v dist.js:1
Yn contacts-main.js:1586
a contacts-main.js:1586
(Async: promise callback)
Yn contacts-main.js:1586
i contacts-main.js:1586
Gn contacts-main.js:1586
Gn contacts-main.js:1586
updateContact contacts.js:325
f vuex.esm.js:847
dispatch vuex.esm.js:512
dispatch vuex.esm.js:402
setPhoto ContactDetailsAvatar.vue:342
e ContactDetailsAvatar.vue:255
l dist.js:1
_invoke dist.js:1
v dist.js:1
T contacts-main.js:600
i contacts-main.js:600
E contacts-main.js:600
E contacts-main.js:600
onloadend ContactDetailsAvatar.vue:223
(Async: EventHandlerNonNull)
processFile ContactDetailsAvatar.vue:223
VueJS 3
Ye
n
_wrapper
EDIT: I can change the avatar, but it's not displayed.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Done :) |
Almost perfect. Only in the list view of the person I share my contacts with, the avatars are either not shown or blanked out. In the details-header, the avatar is shown correctly. No error logs beside |
So as UserA, you share an addressbook with UserB and UserB cannot see avatars in the list? |
Unfortunately yes.
(if I remove the dot an rename |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Fixed @call-me-matt ! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful.
APPROVED.