Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the deprecated OC.Util.relativeModifiedDate by nextcloud/moment #1936

Merged
merged 1 commit into from
Nov 16, 2020

Conversation

tintou
Copy link
Contributor

@tintou tintou commented Nov 15, 2020

As per nextcloud/server#20988 OC.Util.relativeModifiedDate is deprecated.

@codecov
Copy link

codecov bot commented Nov 15, 2020

Codecov Report

Merging #1936 (3528ad2) into master (3eefad8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1936   +/-   ##
=========================================
  Coverage     67.53%   67.53%           
  Complexity      249      249           
=========================================
  Files            22       22           
  Lines           690      690           
=========================================
  Hits            466      466           
  Misses          224      224           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3eefad8...4998ef4. Read the comment docs.

As per nextcloud/server#20988 OC.Util.relativeModifiedDate is deprecated.

Signed-off-by: Corentin Noël <corentin@elementary.io>
@tintou tintou force-pushed the tintou/nextcloud/moment branch from cbb4900 to 4998ef4 Compare November 15, 2020 18:05
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:rock
Nice!! :)

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish enhancement New feature or request labels Nov 16, 2020
@skjnldsv skjnldsv added this to the next milestone Nov 16, 2020
@skjnldsv skjnldsv merged commit 16fb97e into master Nov 16, 2020
@skjnldsv skjnldsv deleted the tintou/nextcloud/moment branch November 16, 2020 06:18
@skjnldsv skjnldsv removed this from the next milestone Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants