Improve Compatibily with macOS Contacts #1999
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1999 +/- ##
============================================
- Coverage 69.83% 0.00% -69.84%
- Complexity 238 249 +11
============================================
Files 22 22
Lines 673 738 +65
============================================
- Hits 470 0 -470
- Misses 203 738 +535
Continue to review full report at Codecov.
|
src/store/addressbooks.js
Outdated
| @@ -346,8 +346,7 @@ const actions = { | |||
| */ | |||
| async getContactsFromAddressBook(context, { addressbook }) { | |||
| return addressbook.dav | |||
| .findAllAndFilterBySimpleProperties(['EMAIL', 'UID', 'CATEGORIES', 'FN', 'ORG', 'N', | |||
| 'X-PHONETIC-FIRST-NAME', 'X-PHONETIC-LAST-NAME']) | |||
| .findAllAndFilterBySimpleProperties(Contact.MinimalContactProperties) | |||
| ICAL.design.vcard3.param.type.multiValueSeparateDQuote = true | ||
| ICAL.design.vcard.param.type.multiValueSeparateDQuote = true |
There was a problem hiding this comment.
Nice! I was not aware of such possibilities :)
There was a problem hiding this comment.
Ah, yes, it was on the old designSet update workaround! Nice! 👍
|
@skjnldsv I have just updated my pull request. |
|
@zlajo only the Developer Code of Origin test fails, could you sign off your commit? :) You just have to |
|
By the way @zlajo we have a Nextcloud Talk instance for easier communication – we also have a channel for Groupware/Contacts there. If you like, we can invite you? :) |
Signed-off-by: Johannes Zlattinger <johannes@zlattinger.net>
|
@jancborchardt I just did a rebase on the current master and a force push. Is this what I had to do? |
I would like to use nextcloud contacts as a replacement to storing my contacts in iCloud. Unfortunately there are some things that don't work as expected and while some issues require fundamental changes (like #609) there are some which I was able to fix with only a few small changes.
One thing I found out was that there already is support for hiding contact groups (as defined by https://tools.ietf.org/html/rfc6350#section-6.1.4). macOS Contacts still uses vCard 3.0 and because of that cannot relay on the vCard kind property defined by vCard 4.0. But there is a proprietary attribute which does the same thing (X-ADDRESSBOOKSERVER-KIND). I updated the contacts app to also respect this Apple specific property and added an easy way to add further proprietary "kind"-properties.
There is also a problem (at least I think so) with the underlying vCard serialization which leads to strange property names. See my comment in src/store/contacts.js for a detailed description of the problem and a potential workaround.
Please let me know if my update works and contact me if further changes/discussions are required.