Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contact deletion from addressbook #2086

Merged
merged 1 commit into from
Feb 24, 2021
Merged

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Feb 24, 2021

I'm not sure why this haven't caused any issue before! 😨

Vue.set(addressbook.contacts, contact.uid, contact)

This is used when moving a contact to an addressbook

await context.commit('deleteContactFromAddressbook', contact)

Maybe this will fix issues like #2021

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added 3. to review Waiting for reviews bug Something isn't working labels Feb 24, 2021
@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #2086 (59de1f1) into master (aafbde2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2086   +/-   ##
=========================================
  Coverage     69.97%   69.97%           
  Complexity      238      238           
=========================================
  Files            22       22           
  Lines           676      676           
=========================================
  Hits            473      473           
  Misses          203      203           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aafbde2...bd3238c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants