Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix call on null in SocialApiService #2351

Merged
merged 2 commits into from
Jul 16, 2021
Merged

Fix call on null in SocialApiService #2351

merged 2 commits into from
Jul 16, 2021

Conversation

juliusknorr
Copy link
Member

Fixes #2348

Gets rid of the magic value 'any' and replaces it with a default null value for the network fallback to take the first matching.

@juliusknorr juliusknorr requested a review from call-me-matt July 15, 2021 07:21
@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #2351 (4e4c80a) into master (0041bcd) will decrease coverage by 0.30%.
The diff coverage is 55.55%.

❗ Current head 4e4c80a differs from pull request most recent head 9641980. Consider uploading reports for the commit 9641980 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2351      +/-   ##
============================================
- Coverage     69.55%   69.25%   -0.31%     
- Complexity      238      246       +8     
============================================
  Files            22       22              
  Lines           680      696      +16     
============================================
+ Hits            473      482       +9     
- Misses          207      214       +7     
Impacted Files Coverage Δ
lib/Cron/SocialUpdate.php 0.00% <0.00%> (ø)
lib/Service/Social/DiasporaProvider.php 87.23% <50.00%> (-1.66%) ⬇️
lib/Service/Social/FacebookProvider.php 88.88% <50.00%> (-1.81%) ⬇️
lib/Service/Social/InstagramProvider.php 86.00% <50.00%> (-1.50%) ⬇️
lib/Service/Social/MastodonProvider.php 86.04% <50.00%> (-1.76%) ⬇️
lib/Service/Social/TumblrProvider.php 92.85% <50.00%> (-3.30%) ⬇️
lib/Service/Social/TwitterProvider.php 85.41% <50.00%> (-1.54%) ⬇️
lib/Service/Social/XingProvider.php 85.36% <50.00%> (-1.82%) ⬇️
lib/Service/Social/GravatarProvider.php 100.00% <100.00%> (ø)
lib/Service/SocialApiService.php 91.15% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7b540c...9641980. Read the comment docs.

@skjnldsv
Copy link
Member

/rebase

juliusknorr and others added 2 commits July 16, 2021 08:19
…match the first social service

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: call-me-matt <matthiash@abwesend.de>
@skjnldsv skjnldsv merged commit c855235 into master Jul 16, 2021
@skjnldsv skjnldsv deleted the bugfix/2348 branch July 16, 2021 08:23
@juliusknorr
Copy link
Member Author

@call-me-matt Thanks for the additional commit, applied and seems to work properly now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SocialApiService: Call to a member function supportsContact() on null
3 participants