Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the line break between sections #24

Merged
merged 1 commit into from
Oct 31, 2016
Merged

Conversation

PatrycjaPuczko
Copy link
Member

This break is fixed now. @nextcloud/contacts Please reviev
screenshot from 2016-10-29 14-19-05

Signed-off-by: Patrycja Romanowska-Puczko <romanowska.patrycja@gmail.com>
@PatrycjaPuczko PatrycjaPuczko added bug Something isn't working 3. to review Waiting for reviews design Related to the design labels Oct 29, 2016
@Henni
Copy link
Member

Henni commented Oct 29, 2016

Change and code makes sense. Haven't tested it yet though.

@jancborchardt
Copy link
Member

Tested and works 👍 great stuff @PatrycjaPuczko! :)

(Hope you manage to set up the developer environment again – just you can ask us @jospoortvliet @hechi @jakobsack or me any time if you need help. :)

@jancborchardt jancborchardt merged commit 1480673 into master Oct 31, 2016
@jancborchardt jancborchardt deleted the fixed-section-break branch October 31, 2016 12:14
@irgendwie
Copy link
Member

Introduces some weird glitches in chromium for me:

2016-10-31-132028_946x399

Can anyone reproduce?

@MariusBluem
Copy link
Member

Reproducable 😁 @irgendwie

@jospoortvliet
Copy link
Member

@PatrycjaPuczko any chance you could see if you can find out what the issue is?!

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress 3. to review Waiting for reviews labels Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working design Related to the design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants