Add new props #613
Add new props #613
Conversation
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
added
3. to review
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
add-new-props
branch
from
834b047 to
cef4c97
Compare
| @@ -83,13 +83,16 @@ | |||
|
|
|||
| <!-- properties iteration --> | |||
| <!-- using contact.key in the key and index as key to avoid conflicts between similar data and exact key --> | |||
| <contact-details-property v-for="(property, index) in sortedProperties" :key="index+contact.key" :index="index" | |||
| <contact-property v-for="(property, index) in sortedProperties" :key="index+contact.key" :index="index" | |||
There was a problem hiding this comment.
We had actually been talking about whether to use both "contact" and "details" or not when naming the component we created for the avatar management issue.
There was a problem hiding this comment.
Nice! What did you settle for? :)
There was a problem hiding this comment.
ContactAvatar, like you. My concern is just that we also have the list avatar to think of.
| <!-- title --> | ||
| <property-title :icon="'icon-add'" :readable-name="t('contacts', 'Add new property')" /> | ||
|
|
||
| <div class="property__row"> |
There was a problem hiding this comment.
An issue? Or was it just a comment stating the awesomeness of bem? :)
There was a problem hiding this comment.
It's the css way of stating the awesomeness of an app maintainer :)
| @@ -35,17 +35,19 @@ export default function parseVcf(data = '', addressbook) { | |||
|
|
|||
| importState.total = vCards.length | |||
|
|
|||
| return vCards.map(vCard => { | |||
| // Not using map because we want to only push valid contacts | |||
| // map force to return at least undefined | |||
There was a problem hiding this comment.
👍 Good to know and it's nice to see a real life example of reduce being used.
| import Multiselect from 'vue-multiselect' | ||
|
|
||
| export default { | ||
| name: 'ContactDetailsAddNewProp', |
There was a problem hiding this comment.
Could you remove "new" from the name or find another way of shortening it? Or like above use just "contact" or "details" but not both?
There was a problem hiding this comment.
Like 'ContactAddNewProp' ?
There was a problem hiding this comment.
Yes we totally can. Can you create a pull request or an issue? :)
Select to allow the addition of new props