Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add not grouped entry #970

Merged
merged 2 commits into from
Mar 4, 2019
Merged

Add not grouped entry #970

merged 2 commits into from
Mar 4, 2019

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Mar 4, 2019

capture d ecran_2019-03-04_12-24-14
Fix #874

@skjnldsv
Add not grouped entry
9357c48 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added enhancement New feature or request 3. to review Waiting for reviews labels Mar 4, 2019
@skjnldsv skjnldsv added this to the next milestone Mar 4, 2019
@skjnldsv skjnldsv self-assigned this Mar 4, 2019
@skjnldsv skjnldsv requested a review from ChristophWurst March 4, 2019 11:25
@skjnldsv
Hide not grouped entry if empty
09fd341 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@codecov
Copy link

codecov bot commented Mar 4, 2019 •
edited
Loading

Codecov Report

Merging #970 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #970   +/-   ##
=======================================
  Coverage   55.88%   55.88%           
=======================================
  Files           4        4           
  Lines          68       68           
=======================================
  Hits           38       38           
  Misses         30       30

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91dd5c3...09fd341. Read the comment docs.

@skjnldsv skjnldsv merged commit be780df into master Mar 4, 2019
@skjnldsv skjnldsv deleted the enhancement/ungrouped branch March 4, 2019 11:41
@zero-24
Copy link
Contributor

zero-24 commented Mar 4, 2019

Thanks. Sorry haven't had a chance to check this again.. Thanks for adding it 👍

@skjnldsv
Copy link
Member Author

skjnldsv commented Mar 4, 2019

You're welcome :)

@skjnldsv skjnldsv modified the milestones: next, 3.0.4 Mar 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Milestone
3.0.4
Development

Successfully merging this pull request may close these issues.
2 participants
@skjnldsv @zero-24