Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public board sharing #14

Open
juliusknorr opened this issue Feb 1, 2017 · 37 comments
Open

Public board sharing #14

juliusknorr opened this issue Feb 1, 2017 · 37 comments

Comments

@juliusknorr
Copy link
Member

juliusknorr commented Feb 1, 2017

In addition to the sharing with internal users, it should be possible to share a board by generating a public link, similar to the files app. When a board is shared via link it should be possible to protect it with a password and to enable or disable write permissions for guest users.

The public share link then shows the corresponding board (without the left sidebar). Functionality that is only available with managing permissions must not be available on public shares (like the board share sidebar, the label management sidebar)

@georgehrke
Copy link
Member

Please also consider a public editing feature :)

@juliusknorr juliusknorr changed the title Public board sharing Public board sharing [$10] Jul 2, 2017
@juliusknorr
Copy link
Member Author

It should be possible to share public boards with contacts from the ContactsManager API.

@juliusknorr juliusknorr added this to the Backlog milestone Nov 13, 2017
@juliusknorr juliusknorr changed the title Public board sharing [$10] Public board sharing [$75] May 11, 2018
@NebriBlackwing
Copy link
Member

Can a better description of requirements to be implemented be written for this? I'm getting more and more familiar with the project but I am completely out to town on what needs to be done for this.

The json api that I've been writing is nearing it's completion and this bounty is tempting!

@juliusknorr
Copy link
Member Author

@Nebri I've updated the first post with some details on how this should look like.

@NebriBlackwing
Copy link
Member

@nextcloud/deck Is there any api / references to generate the shares from the nextcloud core? I'd hate to re-invent the wheel here. Just trying to formulate a plan of attack before I pull up my editor for this.

@juliusknorr
Copy link
Member Author

@Nebri Unfortunately there is no generic share API right now in Nextcloud. The current one is just for files, so we need to build something on our own there. We already do this for the general board sharing, so i think it makes sense to just extend the current acl table to support public links.

We started with some unification of public templates/controllers in 14 but we either need to add a fallback for 13 or wait until 14 is the lowest supported version:

@mennowo
Copy link

mennowo commented Sep 3, 2018

Really hope to see this feature added some time soon! Just added a bit to the bounty.

@NebriBlackwing
Copy link
Member

Life has gotten busy but later this week I will take a serious look at implementing this 👍

@juliusknorr juliusknorr changed the title Public board sharing [$75] Public board sharing [$100] Oct 9, 2018
@NebriBlackwing NebriBlackwing self-assigned this Oct 16, 2018
@NebriBlackwing
Copy link
Member

Going to add a new database table to track generated public links.

Will add in a new menu option from the boards ... menu that will confirm the generation of a new link / deleting existing links.

@juliushaertl what is the procedure for scripting the creation of new database tables when the app gets updated / installed?

@juliusknorr
Copy link
Member Author

Going to add a new database table to track generated public links.

I think it would be fine to just add a field to the board table to have a public link token there. One link per board should be enough, I think.

@juliushaertl what is the procedure for scripting the creation of new database tables when the app gets updated / installed?

When adding a new column/table you can just change the database.xml, but if you want to earn some bonus points, it would be awesome if we could just migrate the existing database schema to migrations (https://docs.nextcloud.com/server/14/developer_manual/app/migrations.html) and after that just add a new migration step for the database changes.

@juliusknorr juliusknorr removed this from the Backlog milestone Oct 25, 2018
@NebriBlackwing NebriBlackwing removed their assignment Nov 7, 2018
@NebriBlackwing
Copy link
Member

Unassigning myself for the time being to encourage other potential bounty hunters to have a go at this. If anyone else would like to take this on by all means feel free to explore what has already been started. I'll revisit this task in the New Year if it's still open at that time.

This is just a bit much for me at the moment.

@alexanderdd
Copy link

alexanderdd commented Feb 25, 2020

@RyanFletcher86 since your last post there was a new year and another new year ;-)

Just checking if you feel like getting this started again?

@Pilzinsel64
Copy link

Yea, this feature would be great! It's the only thing I miss atm. Have to list any point in a onenote notebook that I share with the would.

@niklasgrewe
Copy link

@juliushaertl anything news here?

@moqmar
Copy link

moqmar commented Nov 23, 2021

What does "Planning evaluation (don't pick)" mean? Is this still something that can/should be done by the community?

@cyberstrawberry101
Copy link

I am also running into the issue of wanting to share some Deck boards publicly with a community of ours, and cannot do that because of all of the mentioned issues above. Is there any movement on this or anyone else interested in taking up implementing this feature?

@sefsh
Copy link

sefsh commented Sep 23, 2022

Dang, I just assumed that I would be able to share Decks as I'm able to share files. Appreciated feature!

@Slime-Senpai
Copy link

Hello, is there any news on this? I see that it's been put in Office team, in a "don't pick" section? Is this still open for the community to develop? It's been a year since the move so I'm wondering how it's evolving

@nikurasutan
Copy link

Dang, I just assumed that I would be able to share Decks as I'm able to share files. Appreciated feature!

Same for me, I thought I can use it as a Trello Alternative.

@juliusknorr
Copy link
Member Author

Hello, is there any news on this? I see that it's been put in Office team, in a "don't pick" section? Is this still open for the community to develop? It's been a year since the move so I'm wondering how it's evolving

This is open for anyone to contribute. The office team board is just for planning our teams resources but not representing on what can or should be developed :)

@punkyard

This comment was marked as duplicate.

@aharish
Copy link

aharish commented Nov 24, 2023

Hi @juliushaertl , I'd like to help get this implemented since I'd like to have this feature. I've not contributed to Deck previously, but I'm familiar with the tech stack being used.

Could you help point me in the right direction for:

  • Current implementation of the share feature in the files app so that I can understand how it works, and implement that on the Deck app. If there is now standardized API available for the sharing feature, it'd be great to use that instead.
  • What the best way to store entries/migrations for the public link and sharing settings would be

@juliusknorr
Copy link
Member Author

juliusknorr commented Nov 24, 2023

Awesome to hear that @aharish

Current implementation of the share feature in the files app so that I can understand how it works, and implement that on the Deck app. If there is now standardized API available for the sharing feature, it'd be great to use that instead.
What the best way to store entries/migrations for the public link and sharing settings

There is no such generic API unfortunately. While the oc_share table may indicate that there are different share types those are there for historical reasons. The overall share logic in server is too much bound to files/folders to be of much use here. Other apps implementing public sharing mainly implement their own database to store share data and handle everything within the app.

My suggestion would be to reuse the existing deck_board_acl table and introduce a different type for share links (

public const PERMISSION_TYPE_USER = 0;
) the participant field could be used to store a random token for the link as it is done with files as well.

As this is probably going to be a larger change please don't hesitate to reach out in terms of any questions. Anything we can clarify upfront is probably helping to ease the review process and could avoid larger changes after the implementation has already been started.

Edit: We can also have a chat about this if you want, feel free to ping me by mail for that.

@Casuallynoted
Copy link

I'm curious as to the status of this, I think it would be a massive boost to Deck's capabilities to be bale to share boards via a link (especially for artists and creators).

@TheNomad11
Copy link

TheNomad11 commented Jan 31, 2024

Public boards could make into one of the few (only?) open source Padlet alternatives and would be very useful in education settings

@SamuXzX
Copy link

SamuXzX commented Jan 31, 2024

It could also help with the fact that some of us use an instance of Nextcloud privately, without actually having other people use an account in Nextcloud. I may like to use Nextcloud Deck, if only I could share my work with other people without the absurd request of creating an account on my Nextcloud instance.

@nderambure
Copy link

I'm joining this request, as @SamuXzX said, Padlet is a common tool used in education by default (like zoom...), and sharing decks would be a great argument to leave this proprietary software.

@Adelineenileda

This comment was marked as spam.

@Adelineenileda

This comment was marked as spam.

@jancborchardt jancborchardt moved this to 🧭 Planning evaluation / ideas in 🖍 Design team Jun 6, 2024
@jancborchardt jancborchardt moved this from 🧭 Planning evaluation / ideas to 🏗️ At engineering in 🖍 Design team Oct 17, 2024
@kampty
Copy link

kampty commented Oct 24, 2024

I hope someone manages to implement it, as a Trello alternative would be great

@juliusknorr juliusknorr changed the title Public board sharing [$100] Public board sharing Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🧭 Planning evaluation (don't pick)
Status: 🏗️ At engineering
Development

No branches or pull requests