Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click outside card should close sidebar #1794

Closed
simonspa opened this issue May 3, 2020 · 6 comments · Fixed by #2272
Closed

Click outside card should close sidebar #1794

simonspa opened this issue May 3, 2020 · 6 comments · Fixed by #2272

Comments

@simonspa
Copy link

simonspa commented May 3, 2020

The sidebar opens when clicking on a card, and switches when clicking on another card. To stay in this logic, clicking outside of a card should close the sidebar.

Currently the user has to navigate to the x button top-right to close it.

@jakobroehrl
Copy link
Contributor

@juliushaertl How can solve this issue? Could you give me a hint?

@simonspa
Copy link
Author

There is a Vue module called v-click-outside which is used somewhere in spreed for example - maybe that helps? (don't know myself...)

@stale
Copy link

stale bot commented Sep 5, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added stale and removed stale labels Sep 5, 2020
@fm-sys

This comment has been minimized.

@stefan-niedermann

This comment has been minimized.

@jakobroehrl
Copy link
Contributor

The Esc key should close the sidebar, too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants