Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown URLs in markdown lists cause the checkbox to become a hyperlink and go to the different web page address when clicked #2640

Open
Poikilos opened this issue Dec 9, 2020 · 7 comments

Comments

@Poikilos
Copy link

Poikilos commented Dec 9, 2020

version 1.2.2

A captioned markdown URL eats into the preceding checkbox.

To Reproduce
Steps to reproduce the behavior:

  1. Make a list of markdown URLs with display text such as:
- [ ] U6 [How online presentations work](https://money.howstuffworks.com/business-communications/how-online-presentations-work1.htm) 
- [x] U6 [Remember these 6 facial expression tips when presenting](https://www.duarte.com/presentation-skills-resources/facial-expressions-matter-when-presenting-heres-why/)
- [ ] U6 [Presentation rubrics](https://www.uwstout.edu/academics/online-distance-education/online-professional-development/educational-resources-rubrics/creating-and-using-rubrics-assessment#presentationrubrics)
  1. The checkbox becomes a URL (The square itself is highlighted with the URL color. Clicking it checks it, but also goes to the webpage)

Expected behavior
Exclude the checkbox from the URL if the markdown brackets exclude it.

Screenshots
kanban - link doesn't terminate - live

Client details:

  • OS: Windows 10
  • Browser Firefox
  • Version 83.0
  • Device: desktop
Server details **Operating system**: Ubuntu 20.04

Web server:
Nginx

Database:
PostgreSQL

PHP version:
7.3

Nextcloud version: (see Nextcloud admin page)
19.0.5

Where did you install Nextcloud from:
tarball (then upgraded via GUI several times)

Signing status:

No errors have been found.

List of activated apps:
N/A

If you have access to your command line run e.g.:
sudo -u www-data php occ app:list
from within your Nextcloud installation folder

Nextcloud configuration:
N/A

If you have access to your command line run e.g.:
sudo -u www-data php occ config:list system
from within your Nextcloud installation folder

or

Insert your config.php content here
Make sure to remove all sensitive content such as passwords. (e.g. database password, passwordsalt, secret, smtp password, …)

Are you using an external user-backend, if yes which one: LDAP/ActiveDirectory/Webdav/...
No

Logs

Nextcloud log (data/nextcloud.log)

N/A

Insert your Nextcloud log here

Browser log

N/A
@Poikilos
Copy link
Author

Poikilos commented Dec 11, 2020

Before I forget:
On Android Browser I just noticed that clicking the URL checks and unchecks the box, but doesn't go to the URL, even with a non-URL between the checkbox and the URL. It may be part of the same bug and should probably be tested with the fix for the main issue (reproduce using 2nd list item in code below):

- [x] U6 Presentations
- [ ] U6 [Different Types of Inheritance](http://web.archive.org/web/20200130173101/http://www.programcall.com/20/csnet/types-of-inheritance-in-csnet.aspx)
- [ ] U6 ch 20
- [ ] U6 ch 21

@Poikilos
Copy link
Author

Poikilos commented Dec 17, 2020

In the following example, clicking the third checkbox goes to the URL in the first item:

- [x] [U7 Presentations](https://www.youtube.com/watch?v=p3gYVcggQOU&feature=emb_logo)
- [ ] U7 ch 23
- [ ] U7 [Dotnet. (2015). C# coding conventions](https://msdn.microsoft.com/en-us/library/ff926074.aspx)

  • and the check appears at first, but upon going back (even going back then refreshing), the third box is not really checked.

@daviddash11
Copy link

Hi @Poikilos this is my first ever GitHub report. Maybe it is helpful to @juliushaertl to solve the issue:

(Deck v1.23)
I found out, that if you don't end you bullet point with a dot '.' it will eat up the bullet points that follow
View Mode:
view mode - link is fully writtin

Edit Mode:
edit mode - link is fully writting

Further Bug:

  • I found, that when ever I have a URL inside a checkbox / bullet point, as the picture shows, it will display the Hyperlink + it will write out the code version as well.
  • lastly if you open the card in the large view, it does not let you highlight and copy.

@Zocker1999NET
Copy link

Zocker1999NET commented Jan 31, 2021

seems to be a duplicate of #2109, links are affected of the same issue as other formatting inside a task list, see also other duplicates #2138 and #2769

@Poikilos
Copy link
Author

In the following example, clicking the third checkbox goes to the URL in the first item:

- [x] [U7 Presentations](https://www.youtube.com/watch?v=p3gYVcggQOU&feature=emb_logo)
- [ ] U7 ch 23
- [ ] U7 [Dotnet. (2015). C# coding conventions](https://msdn.microsoft.com/en-us/library/ff926074.aspx)
* and the check appears at first, but upon going back (even going back then refreshing), the third box is not really checked.

This code works correctly in Nextcloud 25.0.1 and Deck 1.8.2

@Poikilos
Copy link
Author

The test in my original post works correctly now as well:

- [ ] U6 [How online presentations work](https://money.howstuffworks.com/business-communications/how-online-presentations-work1.htm) 
- [x] U6 [Remember these 6 facial expression tips when presenting](https://www.duarte.com/presentation-skills-resources/facial-expressions-matter-when-presenting-heres-why/)
- [ ] U6 [Presentation rubrics](https://www.uwstout.edu/academics/online-distance-education/online-professional-development/educational-resources-rubrics/creating-and-using-rubrics-assessment#presentationrubrics)

@Poikilos
Copy link
Author

Feel free to close this issue or let me know if I should.

The test works properly on Chrome browser on Android as well:

Before I forget: On Android Browser I just noticed that clicking the URL checks and unchecks the box, but doesn't go to the URL, even with a non-URL between the checkbox and the URL. It may be part of the same bug and should probably be tested with the fix for the main issue (reproduce using 2nd list item in code below):

- [x] U6 Presentations
- [ ] U6 [Different Types of Inheritance](http://web.archive.org/web/20200130173101/http://www.programcall.com/20/csnet/types-of-inheritance-in-csnet.aspx)
- [ ] U6 ch 20
- [ ] U6 ch 21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants