Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paste image on clipboard directly to comments like GitHub #533

Open
Aesculapius opened this issue Jul 13, 2018 · 17 comments
Open

Paste image on clipboard directly to comments like GitHub #533

Aesculapius opened this issue Jul 13, 2018 · 17 comments

Comments

@Aesculapius
Copy link

Aesculapius commented Jul 13, 2018

The new attachment feature is awesome, it would be even more awesome if screenshots that are taken, can be pasted directly into the description field, like it is done on Github:

image

That would save the step to save into a file and upload that again...


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@juliusknorr
Copy link
Member

@Aesculapius Yes, that would be a great enhancement. 👍

@helloxinxiang
Copy link

It is a very useful function! Would you please develop it? Thanks a lot!

@Paolo-om
Copy link

Paolo-om commented Dec 29, 2019

The only reason I still use Trello instead of deck is, that Trello can paste images from the clipboard directly into the card. It would be nice to get this feature maybe soon on deck.

@jakobroehrl
Copy link
Contributor

implemented in spreed: nextcloud/spreed#3399

@reox
Copy link
Contributor

reox commented Jun 3, 2020

Right now, pasting images creates a huge mess... If you accidently press Ctrl+V if you have an image in the clipboard, it pastes the whole binary content - which is rendered as unicode.
It also hangs the browser for a couple of seconds which is really annoying.
If possible, as long as pasting is not supported, I would opt for blocking pasting images into the description at all.

@reox
Copy link
Contributor

reox commented Jun 7, 2020

Also related: It is already possible to show attached images in the description quite easily - simply use the markdown for the image ![desc](/apps/deck/cards/183/attachment/4) - the url can be directly copied from the uploaded image (or using the attachment icon directly).

So basically everything is already there: You just have to catch the Ctrl+V action with the upload and inserting the correct markdown.

@xv1nx
Copy link

xv1nx commented Jun 9, 2021

now, I can just paste the image and it is also shown correctly. But if I press Enter-key, everything disappears. The cell stays as blank cell.

image

@reox
Copy link
Contributor

reox commented Jun 9, 2021

now, I can just paste the image and it is also shown correctly. But if I press Enter-key, everything disappears. The cell stays as blank cell.

it does not work for me with Deck 1.4.2 and NC 21.0.2 and Firefox 89.
I think certain browser allow that but if the editor does not handle it properly it makes weird things...

@reox
Copy link
Contributor

reox commented Nov 23, 2021

Just to note: #1561 might solve this as well. Nextcloud Text does support pasting images into the markdown editor. However, there they are saved as inline base64 images and not uploaded like it works right now for the attachments. (for me that would not make any difference, as long as the editor is still useable (see drawback below))

And base64 inline images are already supported by the current markdown editor/renderer: paste this in a deck description to get a red dot:

![red dot](data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAUAAAAFCAYAAACNbyblAAAAHElEQVQI12P4//8/w38GIAXDIBKE0DHxgljNBAAO9TXL0Y4OHwAAAABJRU5ErkJggg==)

(Source)

To go even further and as a potential workaround right now: there are browser extensions to paste as markdown. Some support to paste an image from the clipboard just as base64 encoded inline markdown. And this works great.
The only drawback is, a single screenshot will create like a million lines in the editor window 😕

@okow
Copy link

okow commented Mar 2, 2022

I think most of the funtionality is allready there, just a few additional lines of code neccessary to connect the drop-event with the upload-code. But i'm not familiar with vue.js so i just posted a bounty on this. Maybe someone want's to engage also...

@brunodegoyrans
Copy link

I have read several issues around this topic and it seems this feature is waited by many people. But the current situation is not clear to me. Is there something planned? Does anyone from the development team care about?

I can participate to this issue, implement it if I'am allowed to.

Could someone for the dev team make a status?
And if required and possible, explain me how to participate to sw dev?

@juliusknorr
Copy link
Member

Hi @brunodegoyrans This is currently not scheduled for development on our side. However any contributions would be very welcome of course. I think the main question to clarify before diving into implementing this would be how the uploaded images are stored, but this could be basically an attachment to the card which is then just inserted into the markdown content.

For getting started with contributions I'd suggest to head to https://nextcloud.com/contribute/ first. You will need a local development setup of Nextcloud (e.g. https://docs.nextcloud.com/server/latest/developer_manual/getting_started/devenv.html or https://github.com/juliushaertl/nextcloud-docker-dev) where you can then clone the deck app from GitHub and start working on it. For deck itself you can find the relevant steps at https://github.com/nextcloud/deck/blob/master/README.md#developing to get it built from git.

Let me know if you haver any further questions.

@brunodegoyrans
Copy link

Hi @juliushaertl

However any contributions would be very welcome of course.

GREAT. We are going to work on it. Me or my collaborator Rija. We will make our best to fit the team quality requirements.

I think the main question to clarify before diving into implementing this would be how the uploaded images are stored, but this could be basically an attachment to the card which is then just inserted into the markdown content.

This is what I think of.

@RijaRR
Copy link

RijaRR commented Aug 8, 2022

Hi @juliushaertl

I have made a pull request #3951 . The idea is to upload the image as if we have made it through the attachement list.

@viktorix

This comment has been minimized.

@juliusknorr

This comment has been minimized.

@nico-arnold
Copy link

Any updates on this one? I saw the mentioned PR was finally withdrawn and wonder if the feature will be implemented in the future, which would be awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.