Open description links in new tab #2791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
reviewed
Apr 16, 2021
|
@juliushaertl would you mind another review? |
Signed-off-by: Florian Meyer <meyer_florian@magenta.de>
|
Thanks a lot, i took the liberty to fix the linting to use tabs instead of spaces and add the |
Oh, sorry. Had done the same fix and forced pushed as well. Will try to revert my force push... |
|
Ah, I just wondered about that. I'll let you take care then :) |
|
@juliushaertl Force push reverted to commit 6335f50 |
juliusknorr
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With this change, clicking on links in the description will open them in a new tab...
Checklist
Tests (unit, integration, api and/or acceptance) are included-> not necessary