Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve combined search #3344

Merged
merged 1 commit into from
Oct 4, 2021
Merged

Improve combined search #3344

merged 1 commit into from
Oct 4, 2021

Conversation

julien-nc
Copy link
Member

This invalidates #3343.

  • [fix] Board search now uses a cursor and the query limit.
  • [fix] All results are now sorted by last modified date.
  • [enh] Search cursor is now a combination of 2 values, one for boards and one for cards. This way we can really paginate the combined results.

@julien-nc julien-nc force-pushed the enh/paginated-search-for-boards-and-cards branch 2 times, most recently from b667c1b to ee9893c Compare September 30, 2021 11:32
@juliusknorr juliusknorr mentioned this pull request Oct 4, 2021
Merged
@julien-nc julien-nc force-pushed the enh/paginated-search-for-boards-and-cards branch from ee9893c to dcdf91d Compare October 4, 2021 12:49
use distinct pagination cursor for cards and boards, use cursor and l…
b533d11 
…imit in SearchSe

rvice::searchBoards()

Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
@julien-nc julien-nc force-pushed the enh/paginated-search-for-boards-and-cards branch from dcdf91d to b533d11 Compare October 4, 2021 13:23
@julien-nc
Copy link
Member Author

Rebased on master

@juliusknorr
Copy link
Member

/backport to stable22

@juliusknorr
Copy link
Member

/backport to stable1.4

@juliusknorr juliusknorr merged commit c706fb7 into master Oct 4, 2021
@juliusknorr juliusknorr deleted the enh/paginated-search-for-boards-and-cards branch October 4, 2021 14:41
@backportbot-nextcloud
Copy link

The backport to stable22 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable1.4 failed. Please do this backport manually.

This was referenced Oct 4, 2021
Merged
Merged
@juliusknorr juliusknorr mentioned this pull request Oct 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@luka-nextcloud luka-nextcloud Awaiting requested review from luka-nextcloud

Assignees
No one assigned
Labels
3. to review enhancement feature: search
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julien-nc @juliusknorr