Case mismatch in path to Nextcloud.app in MacOS package script for client >= 3.3.0

[znerol]

How to use GitHub

• Please use the 👍 reaction to show that you are affected by the same issue.
• Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
• Subscribe to receive notifications on status change and new comments.

Description

In #3404 the macOS installation path changed from /Applications/nextcloud.app (up to 3.2.4) to /Applications/Nextcloud.app (from 3.3.0 onwards). However, the change in capitalization was not reflected in packaging scripts.

Use the following commands to extract preinstall and postinstall scripts from released packages:

export VERSION=3.3.0
mkdir /tmp/nextcloud-$VERSION
/tmp/nextcloud-$VERSION.pkg
curl -LO "https://github.com/nextcloud/desktop/releases/download/v$VERSION/Nextcloud-$VERSION.pkg"
xar -xf Nextcloud-$VERSION
cpio -zi < Nextcloud.pkg/Scripts
cat postinstall
cat preinstall

The resulting preinstall and postinstall scripts all refer the pre 3.3.0 path /Applications/nextcloud.app and also the old binary name nextcloud at various places.

Client configuration

Client version: 3.3.0, 3.3.1

Operating system: macOS (any version)

OS language: any

Installation path of client: /Applications/Nextcloud.app

[znerol]

I suspect that this might be the cause for #3012 (comment)