Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check any sync database operations for improper error management #4229

Closed
mgallien opened this issue Jan 31, 2022 · 2 comments · Fixed by #4819
Closed

Check any sync database operations for improper error management #4229

mgallien opened this issue Jan 31, 2022 · 2 comments · Fixed by #4819
Assignees
Labels
enhancement enhancement of a already implemented feature/code feature: 🔄 sync engine

Comments

@mgallien
Copy link
Collaborator

Desktop client is relying on a sync database to maintain proper state of a sync folder.
Some access to sync database can generate errors without them being properly handled. Check all such usage to ensure errors are not getting ignored silently.

@mgallien mgallien added enhancement enhancement of a already implemented feature/code feature: 🔄 sync engine labels Jan 31, 2022
@mgallien
Copy link
Collaborator Author

@tobiasKaminsky

@allexzander allexzander self-assigned this Jul 26, 2022
@allexzander
Copy link
Contributor

  • check first that inside SyncJournalDb class we really check any error from low-level methods implementing the DB operations (SqlQuery::exec for example)
  • make it impossible to ignore the return values of methods of the SyncJournalDb class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement enhancement of a already implemented feature/code feature: 🔄 sync engine
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants