Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: skipUpdateCheck=true doesn't skip update check on macOS #4711

Closed
6 of 8 tasks
Tegenwind opened this issue Jul 8, 2022 · 1 comment · Fixed by #4717
Closed
6 of 8 tasks

[Bug]: skipUpdateCheck=true doesn't skip update check on macOS #4711

Tegenwind opened this issue Jul 8, 2022 · 1 comment · Fixed by #4717

Comments

@Tegenwind
Copy link

⚠️ Before submitting, please verify the following: ⚠️

Bug description

Previous to 3.5.1, the desktop client would honor the line "skipUpdateCheck=true" when added to nextcloud.cfg to not bother our end users with an update notification they can't install anyways due to missing permissions (updates are managed with munki).

Alternatively, unticking the "Automatically check for updates" box in the GUI preferences doesn't do anything as it's turned back on as soon you check next.

Steps to reproduce

  1. Install 3.5.1
  2. Add "skipUpdateCheck=true" under "General" to "~/Library/Preferences/Nextcloud/nextcloud.cfg"
  3. Wait for an update

Expected behavior

When updates are turned off either through the GUI or adding "skipUpdateCheck=true" to "nextcloud.cfg", the end user shoudn't be bothered when a new version is released.

Which files are affected by this bug

none

Operating system

Mac OS

Which version of the operating system you are running.

10.15 - 12.4

Package

Other

Nextcloud Server version

irrelevant

Nextcloud Desktop Client version

3.5.*

Is this bug present after an update or on a fresh install?

Fresh desktop client install

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

Are you using an external user-backend?

  • Default internal user-backend
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Nextcloud Server logs

irrelevant

Additional info

It's probably since 3.5.0 but we haven't rolled that out to our end users.

@Tegenwind
Copy link
Author

This was apparently fixed in 3.5.3 and then in 3.6.0, but I'm still getting reports of end users getting pestered by update notifications. They are running 3.6.2, currently.

We are using autoUpdateCheck=false in the config file, and check for update shows as off when checked in the client.

Other than the pop-up being a minor nuisance; if the user does attempt to proceed with the installation, the installer closes the Nextcloud app before installing, even if the user doesn't have permissions to install the update. The user then has to notice and re-open the application, or their changes will not be synced (spoiler: they don't).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants