Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password not saved for new accounts (windows, daily builds) #581

Closed
klada opened this issue Aug 24, 2018 · 4 comments
Closed

Password not saved for new accounts (windows, daily builds) #581

klada opened this issue Aug 24, 2018 · 4 comments
Assignees

Comments

@klada
Copy link

klada commented Aug 24, 2018

When setting up a new account the sync password is not saved in the Windows Credential Store. This means the user needs to reauthenticate after closing and re-opening the sync client.

I suspect this has something to do with the recent upgrade of Qt/QtKeychain, maybe a wrong build option or something like that. I don't think that it has something to do with the QtKeychain 0.9.1 release in general (see #569), as I can confirm that 0.9.1 itself is clean (I compiled a testclient against 0.9.1 and it is working properly).

I could look into this a bit deeper, but I don't have access to the exact build environment bootstrapping mechanism. I am sure you manage the environment dependencies through a platform management tool (Ansible/Chef/Puppet or whatever), would you mind sharing the environment recipe so people can reproduce the environment for debugging?

Steps to reproduce:

  1. Quit Nextcloud, remove current config and sync folder
  2. Remove all Nextcloud credentials from the Windows Credential Manager
  3. Open Nextcloud client (daily build) and set up account
  4. Quit Nextcloud client
  5. Re-open Nextcloud client → password is lost
@camilasan
Copy link
Member

Hi @klada
I am getting to the same conclusion about this bug but I couldn't yet figure out the problem.
Here is the scripts we are using for the builds: https://github.com/nextcloud/client-building
Thanks!

@camilasan
Copy link
Member

camilasan commented Sep 4, 2018

Hi! I think I solved it!Hi! Could you try this build - please make sure to have a clean configuration - https://download.nextcloud.com/desktop/daily/Windows/Nextcloud-2.5.0.61352-daily-20180904.exe?

Thanks!

@klada
Copy link
Author

klada commented Sep 4, 2018

Very nice, this build is saving the password properly again and also includes the latest QtKeychain version. Thank you.

@camilasan
Copy link
Member

The last few commits from https://github.com/nextcloud/client-building fixed the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants