Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix activity list item issues with colours/layout/etc. #4472

Merged
merged 1 commit into from
May 16, 2022
Merged

Fix activity list item issues with colours/layout/etc. #4472

merged 1 commit into from
May 16, 2022

Conversation

claucambra
Copy link
Collaborator

@claucambra claucambra commented May 2, 2022 •
edited
Loading

This PR includes fixes for several critical issues with the activity list items, mainly:

  • Wrong colouration of primary activity actions (e.g. the Reply button)
  • Incorrect activity icon colour in dark mode (changes should also make the code around correct icon selection much cleaner and future proof, as the tray image provider can now recolour SVGs too)
  • Several issues with the talk reply field relating to layout, particularly location of text field and height of activity item once the textfield is invoked and once the message has been sent, as well as readability of text

After fixes:

Screenshot 2022-05-02 at 21 55 12

Screenshot 2022-05-02 at 21 54 22

Before fixes:

Screenshot 2022-05-02 at 18 36 40

@claucambra claucambra force-pushed the bugfix/tray-colours branch 2 times, most recently from 7b38baa to 29bf89c Compare May 2, 2022 19:59
@claucambra claucambra self-assigned this May 2, 2022
@claucambra claucambra force-pushed the bugfix/tray-colours branch 2 times, most recently from 47bacd0 to eb75dbc Compare May 3, 2022 09:12
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4472-eb75dbc92cd5b9d37e015d35c038d175dba93bdd-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien
Copy link
Collaborator

mgallien commented May 4, 2022

/backport to stable-3.5

@claucambra claucambra force-pushed the bugfix/tray-colours branch from eb75dbc to 7209589 Compare May 16, 2022 13:41
@claucambra
Fixed several issues with activity items relating to icon colouration…
4634961 
… and activity item sizing + layout

Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
@claucambra claucambra force-pushed the bugfix/tray-colours branch from 7209589 to 4634961 Compare May 16, 2022 14:42
@claucambra claucambra merged commit 96e4fce into master May 16, 2022
@claucambra claucambra deleted the bugfix/tray-colours branch May 16, 2022 14:43
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request May 16, 2022
Merged
@sonarcloud
Copy link

sonarcloud bot commented May 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mgallien mgallien added this to the 3.6.0 milestone May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allexzander allexzander allexzander approved these changes

@mgallien mgallien mgallien approved these changes

@camilasan camilasan Awaiting requested review from camilasan

Assignees

@claucambra claucambra

Labels
None yet
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@claucambra @nextcloud-desktop-bot @mgallien @allexzander