l10n: Fixed grammar #4495
l10n: Fixed grammar #4495
Conversation
|
@rakekniven @mgallien What about the singular for "minute"? In Transifex, the sentence for the singular and the plural is the same. |
Yes, but the translator can translate it. |
A translator who knows what it is all about. Inexperienced translators translate one-to-one without changing a word. |
src/gui/sharedialog.cpp
Outdated
| @@ -102,7 +102,7 @@ ShareDialog::ShareDialog(QPointer<AccountState> accountState, | |||
| const auto lockExpirationTime = _filelockState._lockTime + _filelockState._lockTimeout; | |||
| const auto remainingTime = QDateTime::currentDateTime().secsTo(QDateTime::fromSecsSinceEpoch(lockExpirationTime)); | |||
| const auto remainingTimeInMinute = static_cast<int>(remainingTime > 0 ? remainingTime / SECONDS_PER_MINUTE : 0); | |||
| _ui->label_lockinfo->setText(tr("Locked by %1 - Expire in %2 minutes", "remaining time before lock expire", remainingTimeInMinute).arg(_filelockState._lockOwnerDisplayName).arg(remainingTimeInMinute)); | |||
| _ui->label_lockinfo->setText(tr("Locked by %1 - Expires in %2 minutes", "remaining time before lock expire", remainingTimeInMinute).arg(_filelockState._lockOwnerDisplayName).arg(remainingTimeInMinute)); | |||
There was a problem hiding this comment.
shouldn't the second string be:
remaining time before lock expires
There was a problem hiding this comment.
This string is not part of the string which is translated.
See https://doc.qt.io/qt-5/i18n-source-translation.html#disambiguation for details.
But you are right. Every spelling mistake should be fixed.
|
@rakekniven can you have a quick look at the conflict and see if you can solve it ? |
Done |
mgallien
force-pushed
the
rakekniven-patch-1
branch
from
792cdda to
1df3b18
Compare
Reported at Transifex. Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
mgallien
force-pushed
the
rakekniven-patch-1
branch
from
1df3b18 to
276616d
Compare
|
AppImage file: Nextcloud-PR-4495-276616d211bd6cc25c4084907f1b03a7d9db40f3-x86_64.AppImage |
|
Kudos, SonarCloud Quality Gate passed! |
Reported at Transifex.
Signed-off-by: rakekniven 2069590+rakekniven@users.noreply.github.com