Make user status dialog look in line with the rest of the desktop client tray and Nextcloud

[claucambra]

Currently, the components of the user status selection dialog are not styled at all:

This means the dialog doesn't follow the system theme and it also looks different from the server's user status selection dialog.

This PR changes that so that the elements of the dialog match the system theme as well as the rest of the desktop client tray and the user status selection dialog of the server:

[jancborchardt]

Awesome @claucambra! :) Just 3 suggestions:

• The text and sublines of the Do not disturb and Invisible status are a bit far apart, maybe half that
• The border of the status input field looks a bit dark, or is that standard
• For better alignment of the status suggestions, the emojis and text should have a bit more whitespace inbetween, so that the emojis line up with the emoji picker above, and the text left-aligns with the input field text "What is your status?"

[claucambra]

Awesome @claucambra! :) Just 3 suggestions:

• The text and sublines of the Do not disturb and Invisible status are a bit far apart, maybe half that
• The border of the status input field looks a bit dark, or is that standard
• For better alignment of the status suggestions, the emojis and text should have a bit more whitespace inbetween, so that the emojis line up with the emoji picker above, and the text left-aligns with the input field text "What is your status?"

Hey @jancborchardt, some changes to fit your suggestions:

[splitt3r]

Great work! This looks pretty neet.

[jancborchardt]

@claucambra the text just needs to move a bit to the right, see this illustration :)
Also little detail: Since we are trying to get rid of the word "user" in the interface, let’s just title the dialog "Set status".

[claucambra]

@claucambra the text just needs to move a bit to the right, see this illustration :) Also little detail: Since we are trying to get rid of the word "user" in the interface, let’s just title the dialog "Set status".

Forgive me but I can't really see the issue here, everything seems aligned? Or would you like the text in general to have more padding?

[codecov]

Codecov Report

Merging #4624 (3501640) into master (f27aa4f) will increase coverage by 0.04%.
The diff coverage is n/a.

❗ Current head 3501640 differs from pull request most recent head 50b4282. Consider uploading reports for the commit 50b4282 to get more accurate results

@@            Coverage Diff             @@
##           master    #4624      +/-   ##
==========================================
+ Coverage   56.52%   56.56%   +0.04%     
==========================================
  Files         138      138              
  Lines       17071    17071              
==========================================
+ Hits         9649     9656       +7     
+ Misses       7422     7415       -7     

Impacted Files	Coverage Δ
src/libsync/propagatedownload.cpp	65.18% <0.00%> (+1.03%)	⬆️

[mgallien]

@claucambra please do no forget to clean history as one more time I forgot to ask this before approving

[jancborchardt]

@claucambra yes sorry – you need to compare my screenshot (with the red lines) with the one you posted before that. :) I moved the text slightly to the right in mine.

[claucambra]

@claucambra yes sorry – you need to compare my screenshot (with the red lines) with the one you posted before that. :) I moved the text slightly to the right in mine.

Ah! Sorry 🤦‍♂️ here is an updated version:

[nimishavijay]

Looks really nice now! 🚀🚀🚀🚀 :)

Edit: I thought it needed some padding on the outside, but on second thought it looks great already :)

[mgallien]

Looks really nice now! rocketrocketrocketrocket :)

Edit: I thought it needed some padding on the outside, but on second thought it looks great already :)

@nimishavijay could you add your approval such that we can merge it ?

[mgallien]

@claucambra there is a conflict, can you have a look ?

[claucambra]

@claucambra there is a conflict, can you have a look ?

Rebased and solved :)

[mgallien]

@claucambra there is again a conflict, can you have a look ?

[mgallien]

@claucambra please clean history before merging

[claucambra]

@mgallien squashed and rebased

[nextcloud-desktop-bot]

AppImage file: Nextcloud-PR-4624-ee3e0d335182617b5c9140882ca725d48ccbe07e-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information