Ensure the dispatch source only gets deallocated after the dispatch_source_cancel is done, avoiding crashing of the Finder Sync Extension on macOS #4643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgallien
reviewed
Jun 15, 2022
shell_integration/MacOSX/OwnCloudFinderSync/FinderSyncExt/LocalSocketClient.m
Show resolved
Hide resolved
mgallien
approved these changes
Jun 17, 2022
allexzander
approved these changes
Jul 1, 2022
…ource_cancel is done Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
claucambra
force-pushed
the
bugfix/finder-sync-crashing
branch
from
a9b900d to
a74f9b3
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #4643 +/- ##
=======================================
Coverage 56.41% 56.41%
=======================================
Files 138 138
Lines 17068 17068
=======================================
Hits 9629 9629
Misses 7439 7439 |
|
AppImage file: Nextcloud-PR-4643-a74f9b367d19a387cdf26d8f241ad925956ce9f1-x86_64.AppImage |
|
/backport to stable-3.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
dispatch_source_cancelworks asynchronously, deallocating the dispatch source synchronously runs the risk of deallocating it beforedispatch_source_cancelhas completed, causing a crash.This PR sets a completion handler that holds a strong reference to the dispatch source to be deallocated, ensuring that the dispatch source is only deallocated after the
dispatch_source_cancelis done.Close #4459