Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'db/local/remote' reference to log string. #4683

Merged
merged 1 commit into from
Jul 5, 2022
Merged

Conversation

camilasan
Copy link
Member

... because every time I see that line 'Processing... ' in the logs I have to figure out/think where each value is from - db or local or remote.

@camilasan camilasan requested review from mgallien, claucambra and allexzander and removed request for mgallien June 29, 2022 14:58
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so true

@mgallien mgallien force-pushed the enh/discovery-logs branch from c1f5bee to 7b8e68f Compare June 30, 2022 13:17
@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #4683 (6be5cb9) into master (0823729) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4683      +/-   ##
==========================================
- Coverage   56.57%   56.55%   -0.02%     
==========================================
  Files         138      138              
  Lines       17068    17068              
==========================================
- Hits         9656     9653       -3     
- Misses       7412     7415       +3     
Impacted Files Coverage Δ
src/libsync/discovery.cpp 84.56% <ø> (-0.30%) ⬇️

@mgallien mgallien force-pushed the enh/discovery-logs branch from 7b8e68f to eb7e019 Compare June 30, 2022 13:53
@camilasan camilasan force-pushed the enh/discovery-logs branch from eb7e019 to 0c43586 Compare July 4, 2022 11:13
Signed-off-by: Camila <hello@camila.codes>
@mgallien mgallien force-pushed the enh/discovery-logs branch from 0c43586 to 6be5cb9 Compare July 5, 2022 16:35
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4683-6be5cb9f786eefe39344e750db3865eed4684364-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Jul 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@mgallien mgallien merged commit dfe2ef8 into master Jul 5, 2022
@mgallien mgallien deleted the enh/discovery-logs branch July 5, 2022 21:16
@mgallien mgallien added this to the 3.6.0 milestone Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants