New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/enable more warnings also for gcc #4804

Merged

camilasan merged 2 commits into master from feature/enableMoreWarningsAlsoForGcc

Aug 10, 2022

Collaborator

mgallien commented Aug 2, 2022

No description provided.

mgallien requested review from camilasan, allexzander and claucambra

August 2, 2022 15:24

claucambra approved these changes

View reviewed changes

Collaborator

claucambra left a comment

Minor comments, otherwise looks good

src/gui/sharelinkwidget.cpp Outdated Show resolved Hide resolved

mgallien force-pushed the feature/enableMoreWarningsAlsoForGcc branch from 18cc3c2 to 21e5541 Compare

August 3, 2022 14:56

codecov bot commented Aug 3, 2022 •

edited

Loading

Codecov Report

Merging #4804 (5c7b6e7) into master (cce7ed7) will increase coverage by 0.12%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #4804      +/-   ##
==========================================
+ Coverage   57.08%   57.21%   +0.12%     
==========================================
  Files         138      138              
  Lines       17144    17144              
==========================================
+ Hits         9787     9809      +22     
+ Misses       7357     7335      -22

Impacted Files	Coverage Δ
...bsync/propagateremotedeleteencryptedrootfolder.cpp	`0.00% <0.00%> (ø)`
src/libsync/syncengine.cpp	`87.22% <0.00%> (+0.54%)`	⬆️
src/libsync/vfs/cfapi/cfapiwrapper.cpp	`74.25% <0.00%> (+1.36%)`	⬆️
src/libsync/vfs/cfapi/vfs_cfapi.cpp	`87.45% <0.00%> (+2.35%)`	⬆️
src/libsync/vfs/cfapi/hydrationjob.cpp	`56.45% <0.00%> (+3.76%)`	⬆️

camilasan approved these changes

View reviewed changes

Member

camilasan commented Aug 10, 2022

/rebase

nextcloud-command force-pushed the feature/enableMoreWarningsAlsoForGcc branch from 21e5541 to 46afd08 Compare

August 10, 2022 11:57

Member

camilasan commented Aug 10, 2022

/rebase

mgallien added 2 commits

August 10, 2022 12:02


          use -Wall -Wextra -Wpedantic when compiling with current gcc versions

4cb87f5

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>


          fix warnings reported by Qt

5c7b6e7

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

nextcloud-command force-pushed the feature/enableMoreWarningsAlsoForGcc branch from 46afd08 to 5c7b6e7 Compare

August 10, 2022 12:02

nextcloud-desktop-bot commented Aug 10, 2022

AppImage file: Nextcloud-PR-4804-5c7b6e7af44e04dadcaeb3cf9ef5626f9fa725b1-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

sonarcloud bot commented Aug 10, 2022

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

camilasan merged commit ddcb834 into master

camilasan deleted the feature/enableMoreWarningsAlsoForGcc branch

August 10, 2022 12:32

mgallien added this to the 3.6.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet