Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs with setting 'Away' user status #4822

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

claucambra
Copy link
Collaborator

@claucambra claucambra commented Aug 5, 2022

We have some bugs around setting the Away status due to bad parsing to string, this PR fixes these issues

Signed-off-by: Claudio Cambra claudio.cambra@gmail.com

@claucambra claucambra self-assigned this Aug 5, 2022
@claucambra claucambra force-pushed the bugfix/userstatusselector-away branch 2 times, most recently from 5a69fc2 to 127c69b Compare August 5, 2022 17:58
@claucambra claucambra changed the title Fix bugs with setting away user state and handling of default/unset user status Fix bugs with setting 'Away' user status Aug 5, 2022
@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #4822 (127c69b) into master (ec2bba7) will decrease coverage by 0.42%.
The diff coverage is 0.00%.

❗ Current head 127c69b differs from pull request most recent head 2209052. Consider uploading reports for the commit 2209052 to get more accurate results

@@            Coverage Diff             @@
##           master    #4822      +/-   ##
==========================================
- Coverage   57.22%   56.79%   -0.43%     
==========================================
  Files         138      138              
  Lines       17144    17143       -1     
==========================================
- Hits         9811     9737      -74     
- Misses       7333     7406      +73     
Impacted Files Coverage Δ
src/libsync/ocsuserstatusconnector.cpp 6.09% <0.00%> (ø)
src/libsync/syncoptions.cpp 20.00% <0.00%> (-45.72%) ⬇️
src/libsync/configfile.cpp 16.69% <0.00%> (-9.05%) ⬇️
src/libsync/theme.cpp 12.07% <0.00%> (-0.61%) ⬇️
src/libsync/vfs/cfapi/cfapiwrapper.cpp 74.25% <0.00%> (-0.46%) ⬇️
src/libsync/syncengine.cpp 87.20% <0.00%> (-0.03%) ⬇️
src/libsync/syncengine.h 43.75% <0.00%> (ø)

Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
@claucambra claucambra force-pushed the bugfix/userstatusselector-away branch from 127c69b to 2209052 Compare August 8, 2022 15:34
@sonarcloud
Copy link

sonarcloud bot commented Aug 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4822-2209052f70428c50799d71fdbb50d320ad7da17d-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@claucambra claucambra merged commit d57d1e3 into master Aug 8, 2022
@claucambra claucambra deleted the bugfix/userstatusselector-away branch August 8, 2022 16:24
@mgallien mgallien added this to the 3.6.0 milestone Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants