Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update client image #5002

Merged
merged 2 commits into from
Oct 4, 2022
Merged

Update client image #5002

merged 2 commits into from
Oct 4, 2022

Conversation

camilasan
Copy link
Member

No description provided.

@camilasan camilasan force-pushed the update-client-image branch from d00b675 to 2a632cf Compare October 3, 2022 15:12
@codecov
Copy link

codecov bot commented Oct 3, 2022 •
edited
Loading

Codecov Report

Merging #5002 (5def959) into master (b9f6d91) will increase coverage by 0.01%.
The diff coverage is 72.72%.

❗ Current head 5def959 differs from pull request most recent head b1d8390. Consider uploading reports for the commit b1d8390 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5002      +/-   ##
==========================================
+ Coverage   57.22%   57.23%   +0.01%     
==========================================
  Files         138      138              
  Lines       17359    17359              
==========================================
+ Hits         9933     9935       +2     
+ Misses       7426     7424       -2
Impacted Files Coverage Δ
src/common/syncjournaldb.h 66.66% <ø> (ø)
src/libsync/discoveryphase.h 25.00% <ø> (ø)
src/libsync/syncengine.h 43.75% <ø> (ø)
src/libsync/discovery.cpp 83.66% <70.58%> (ø)
src/libsync/syncengine.cpp 83.33% <71.29%> (ø)
src/common/syncjournaldb.cpp 77.54% <100.00%> (ø)
src/libsync/propagatedownload.cpp 64.61% <0.00%> (+0.14%) ⬆️
... and 2 more

@mgallien mgallien force-pushed the update-client-image branch 2 times, most recently from d39970d to df6526f Compare October 3, 2022 23:32
@camilasan
Copy link
Member Author

/rebase

@mgallien mgallien force-pushed the update-client-image branch from 54a7d7b to 9c6fa0d Compare October 4, 2022 09:50
@camilasan
Copy link
Member Author

/rebase

@camilasan camilasan force-pushed the update-client-image branch from ab0834d to 5def959 Compare October 4, 2022 11:38
@camilasan
Copy link
Member Author

/rebase

Camila added 2 commits October 4, 2022 13:41
Update to docker image to client-5.15-11.
f6f650c 
Signed-off-by: Camila <hello@camila.codes>
Remove clang-tidy from .drone.yml.
b1d8390 
It is being replaced by GH actions.

Signed-off-by: Camila <hello@camila.codes>
@camilasan camilasan force-pushed the update-client-image branch from 5def959 to b1d8390 Compare October 4, 2022 11:42
@sonarcloud
Copy link

sonarcloud bot commented Oct 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5002-b1d8390dfeed623f1b13c90a6af5646b5d95b8c3-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@camilasan camilasan merged commit 3796e03 into master Oct 4, 2022
@camilasan camilasan deleted the update-client-image branch October 4, 2022 13:35
@mgallien mgallien added this to the 3.7.0 milestone Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien approved these changes

@allexzander allexzander Awaiting requested review from allexzander

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@camilasan @nextcloud-desktop-bot @mgallien