Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernise and improve code in AccountManager #5026

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Modernise and improve code in AccountManager #5026

merged 1 commit into from
Oct 26, 2022

Conversation

claucambra
Copy link
Collaborator

Mostly just:

  • More use of constexpr, const auto and auto where possible
  • Removing foreach
  • Replace inscrutable one or two letter variable names with readable names

@claucambra claucambra changed the title Modernise and improve code in AccountManager and AccountSettings Modernise and improve code in AccountManager Oct 10, 2022
@claucambra claucambra force-pushed the bugfix/modernise-account-code branch from 0d5c5d2 to a89cfc6 Compare October 10, 2022 11:02
@claucambra claucambra self-assigned this Oct 10, 2022
@claucambra claucambra mentioned this pull request Oct 10, 2022
Merged
@claucambra
Constexpr settings constant strings, expand use of const and auto, mo…
a537df2 
…dernise, in accountsmanager

Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
@claucambra claucambra force-pushed the bugfix/modernise-account-code branch from a89cfc6 to a537df2 Compare October 26, 2022 11:28
@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

9.3% 9.3% Coverage
0.0% 0.0% Duplication

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5026-a537df296bd22c7d608073b36ed09455e5169e06-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@claucambra claucambra merged commit 2abbe5c into master Oct 26, 2022
@claucambra claucambra deleted the bugfix/modernise-account-code branch October 26, 2022 17:11
@mgallien mgallien added this to the 3.7.0 milestone Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien approved these changes

@camilasan camilasan Awaiting requested review from camilasan

@allexzander allexzander Awaiting requested review from allexzander

Assignees

@claucambra claucambra

Labels
None yet
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@claucambra @nextcloud-desktop-bot @mgallien