Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make user status selector modal, show user header #5145

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

claucambra
Copy link
Collaborator

Per the design discussion

Screen.Recording.2022-11-09.at.14.09.56.mov

Signed-off-by: Claudio Cambra claudio.cambra@nextcloud.com

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! :)

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra claucambra force-pushed the feature/userstatusselector-modal branch from 83690ab to 8315770 Compare November 9, 2022 16:39
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5145-8315770467c31198785fa1b58e760303b2c568b8-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Nov 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@claucambra claucambra merged commit de7976e into master Nov 9, 2022
@claucambra claucambra deleted the feature/userstatusselector-modal branch November 9, 2022 17:16
@mgallien mgallien added this to the 3.7.0 milestone Nov 24, 2022
@claucambra
Copy link
Collaborator Author

Need to backport as this fixes a polish loop in 3.6+

@claucambra
Copy link
Collaborator Author

/backport to stable-3.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants