Fix bad custom button alignments, sizings, etc. #5189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5189 +/- ##
==========================================
+ Coverage 57.59% 57.80% +0.20%
==========================================
Files 138 138
Lines 17399 17441 +42
==========================================
+ Hits 10021 10081 +60
+ Misses 7378 7360 -18
|
claucambra
force-pushed
the
bugfix/custom-buttons-alignments
branch
from
002911a to
ac2eb63
Compare
allexzander
approved these changes
Nov 24, 2022
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
claucambra
force-pushed
the
bugfix/custom-buttons-alignments
branch
from
ac2eb63 to
d24a400
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
AppImage file: nextcloud-PR-5189-d24a40012e9f98f35182cf59858df2eb3661c326-x86_64.AppImage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our custom buttons implementation has some bugs with alignments and sizings that makes our buttons sometimes look either weird or broken. This PR fixes these issues
Signed-off-by: Claudio Cambra claudio.cambra@nextcloud.com