Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not assert when sharing to a circle #5310

Merged
merged 1 commit into from
Jan 6, 2023
Merged

do not assert when sharing to a circle #5310

merged 1 commit into from
Jan 6, 2023

Conversation

mgallien
Copy link
Collaborator

@mgallien mgallien commented Jan 6, 2023

Signed-off-by: Matthieu Gallien matthieu.gallien@nextcloud.com

claucambra
claucambra approved these changes Jan 6, 2023
View reviewed changes
Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nitpick

src/gui/sharemanager.cpp Outdated Show resolved Hide resolved
@mgallien
do not assert when sharing to a circle
d91e220 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien force-pushed the bugfix/doNotTriggerAssertOnShareToCircle branch from 172a67e to d91e220 Compare January 6, 2023 15:19
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5310-d91e22035898ffe53f90aa6801e17a1ffc62a706-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Jan 6, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@mgallien mgallien merged commit 8f87709 into stable-3.6 Jan 6, 2023
@mgallien mgallien deleted the bugfix/doNotTriggerAssertOnShareToCircle branch January 6, 2023 16:34
@mgallien mgallien added this to the 3.7.0 milestone Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra approved these changes

@camilasan camilasan Awaiting requested review from camilasan

@allexzander allexzander Awaiting requested review from allexzander

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mgallien @nextcloud-desktop-bot @claucambra