Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Deny" Group permission prevails over "allow" User permission #2812

Closed
slaver666 opened this issue Feb 9, 2024 · 10 comments
Closed

"Deny" Group permission prevails over "allow" User permission #2812

slaver666 opened this issue Feb 9, 2024 · 10 comments
Labels
bug feature: acl Items related to the groupfolders ACL or "Advanced Permissions" high high priority

Comments

@slaver666
Copy link

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Steps to reproduce

  1. User has extended permission to the root folder. Group has read permissions to the root folder.
  2. User creates a folder inside root folder. The child folder inherits root folder permissions.
  3. User removes Group read permission to the child folder.

Expected behaviour

User must have all permissions to the folder.

Actual behaviour

User even doesn't see the folder any more.

Server configuration

Operating system:
Ubuntu Linux 22.04.3 LTS

Web server:
Nginx 1.25.3

Database:
PostgreSQL 15.5

PHP version:
8.2

Nextcloud version: (see Nextcloud admin page)
28.0.2

Group folders version:
16.0.3

Updated from an older Nextcloud/ownCloud or fresh install:
updated from 27

Where did you install Nextcloud from:
community edition from official site

Are you using external storage, if yes which one: local/s3/smb/sftp/...
no

Are you using encryption: yes/no
no

Are you using an external user-backend, if yes which one: LDAP/ActiveDirectory/Webdav/Saml/...
Active Directory

Client configuration

Browser:
Google Chrome, Microsoft Edge

Operating system:
Windows 10, Ubuntu Linux 22

Logs

Can't see any log entries belonged to Group folders app

Web server error log

Web server error log
No errors in web server log

Nextcloud log (data/nextcloud.log)

Nextcloud log
[Uploading nextcloud.log…]()


Browser log

Browser log
Insert your browser log here, this could for example include:

a) The javascript console log
b) The network log
c) ...
@slaver666 slaver666 added 0. Needs triage Issues that need to be triaged bug labels Feb 9, 2024
@slaver666
Copy link
Author

nextcloud.log

@Jerome-Herbinet
Copy link
Member

Hi @slaver666,
Can you detail a way to reproduce the bug. This will allow me to see if it's the same bug as the one I found on my side.
Thx

@koelle25
Copy link

koelle25 commented Mar 1, 2024

@Jerome-Herbinet Do the Steps to reproduce from the OP not work for reproducing the issue? If not can you elaborate what result you see instead?

Steps to reproduce

1. User has extended permission to the root folder. Group has read permissions to the root folder.
2. User creates a folder inside root folder. The child folder inherits root folder permissions.
3. User removes Group read permission to the child folder.

Expected behaviour

User must have all permissions to the folder.

Actual behaviour

User even doesn't see the folder any more.

@slaver666
Copy link
Author

Hi @slaver666, Can you detail a way to reproduce the bug. This will allow me to see if it's the same bug as the one I found on my side. Thx

Hi. I thought my "Steps to reproduce" are well described. I'm ready to give any information/screenshots if you need.

@Jerome-Herbinet
Copy link
Member

@Jerome-Herbinet Do the Steps to reproduce from the OP not work for reproducing the issue? If not can you elaborate what result you see instead?

Steps to reproduce

1. User has extended permission to the root folder. Group has read permissions to the root folder.
2. User creates a folder inside root folder. The child folder inherits root folder permissions.
3. User removes Group read permission to the child folder.

Expected behaviour

User must have all permissions to the folder.

Actual behaviour

User even doesn't see the folder any more.

I read it again, and I think the description is good. Test and result are similar to mine.

@Jerome-Herbinet Jerome-Herbinet added high high priority feature: acl Items related to the groupfolders ACL or "Advanced Permissions" and removed needs info 0. Needs triage Issues that need to be triaged labels Mar 1, 2024
@fschrempf
Copy link
Contributor

I think this is one of the many issues which all describe the same kind of defect. The inherited permissions from the root folder are not taken into account when there is a deny rule for the subdirectory.

Please read through #1212 and other related reports and you might come to the same conclusion as me, which is that groupfolder ACLs are a total mess and pretty much unusable.

@motiosw
Copy link

motiosw commented Mar 25, 2024

I am in the admin and in the employee group. When I restrict a permission for the employee group, I lose access to that folder. By adding me as person with all permissions, I still have no access. I am looking forward for a solution.

@chaosgrid
Copy link

chaosgrid commented May 14, 2024

I just want to add that this behaviour definitely changed within the last year (not exactly sure when).

It is also easy to reproduce:

Make a folder which inherits read permission i.e. of an "admin" group.
Now explicitly deny read access to a "team_member" group to this folder, of which you are also a member. The deny entry now has priority over the inherited read permission of the "admin" group of the parent folder.

I assume this is not intended behaviour and I'm suprised this bug has not been fixed yet..

I also think this is related to or a duplicate of #2934

@chaosgrid
Copy link

I think this issue is also fixed by following this post: #2934 (comment)
It is not a bug, but a feature which changed the default permission behaviour when there are inherited permissions.

@provokateurin
Copy link
Member

Duplicate of #598

@provokateurin provokateurin marked this as a duplicate of #598 Sep 17, 2024
@provokateurin provokateurin closed this as not planned Won't fix, can't repro, duplicate, stale Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature: acl Items related to the groupfolders ACL or "Advanced Permissions" high high priority
Projects
None yet
Development

No branches or pull requests

7 participants